Skip to content

Instantly share code, notes, and snippets.

@aaronkollasch
Created December 6, 2021 02:16
Show Gist options
  • Select an option

  • Save aaronkollasch/24d224c0711cfcd38fa3688f95997f86 to your computer and use it in GitHub Desktop.

Select an option

Save aaronkollasch/24d224c0711cfcd38fa3688f95997f86 to your computer and use it in GitHub Desktop.
Test code for electron macOS cmd+shift+arrow detection
<!DOCTYPE html>
<html>
<head>
<meta charset="UTF-8">
<!-- https://developer.mozilla.org/en-US/docs/Web/HTTP/CSP -->
<meta http-equiv="Content-Security-Policy" content="default-src 'self'; script-src 'self'">
<link href="./styles.css" rel="stylesheet">
<title>Hello World!</title>
</head>
<body>
<h1>Hello World!</h1>
We are using Node.js <span id="node-version"></span>,
Chromium <span id="chrome-version"></span>,
and Electron <span id="electron-version"></span>.
<!-- You can also require other files to run in this process -->
<script src="./renderer.js"></script>
</body>
</html>
/*
Steps to reproduce:
- In System Preferences, set keyboard shortcuts to use Cmd-Left and Cmd-Right
- Use this main.js file with https://github.com/electron/electron-quick-start
- Try pressing Cmd+Shift+Left and Cmd+Shift+Right.
The MenuItems will respond and print CursorHomeSelect and CursorEndSelect.
However, the DevTools console will not.
This appears to be a Chromium issue, as running this code in Chromium's DevTools:
> window.addEventListener('keydown', (e) => {console.log(e);});
does not report Cmd+Shift+Left and Cmd+Shift+Right in Chromium, while it works fine in Firefox.
*/
// Modules to control application life and create native browser window
const {app, BrowserWindow, Menu, MenuItem} = require('electron')
const path = require('path')
function createWindow () {
// Create the browser window.
const mainWindow = new BrowserWindow({
width: 800,
height: 600,
webPreferences: {
preload: path.join(__dirname, 'preload.js')
}
})
// and load the index.html of the app.
mainWindow.loadFile('index.html')
// Open the DevTools.
mainWindow.webContents.openDevTools()
// The dev console will print all key presses except ArrowLeft and ArrowRight while Shift+Cmd are pressed.
// It will only print ArrowLeft and ArrowRight if Shift+Cmd are not pressed.
mainWindow.webContents.executeJavaScript(`
window.addEventListener('keydown', (e) => {
console.log(e);
});
`);
}
// MenuItems do respond to Cmd+Shift+Left and Cmd+Shift+Right.
// (Commenting out the MenuItems does not fix the above event listener.)
const menu = new Menu()
menu.append(new MenuItem({
label: 'Edit',
submenu: [{
role: 'help',
accelerator: process.platform === 'darwin' ? 'Cmd+Shift+Left' : 'Ctrl+Shift+Left',
click: () => { console.log('CursorHomeSelect') }
},
{
role: 'help',
accelerator: process.platform === 'darwin' ? 'Cmd+Shift+Right' : 'Ctrl+Shift+Right',
click: () => { console.log('CursorEndSelect') }
}]
}))
Menu.setApplicationMenu(menu)
// This method will be called when Electron has finished
// initialization and is ready to create browser windows.
// Some APIs can only be used after this event occurs.
app.whenReady().then(() => {
createWindow()
app.on('activate', function () {
// On macOS it's common to re-create a window in the app when the
// dock icon is clicked and there are no other windows open.
if (BrowserWindow.getAllWindows().length === 0) createWindow()
})
})
// Quit when all windows are closed, except on macOS. There, it's common
// for applications and their menu bar to stay active until the user quits
// explicitly with Cmd + Q.
app.on('window-all-closed', function () {
if (process.platform !== 'darwin') app.quit()
})
// In this file you can include the rest of your app's specific main process
// code. You can also put them in separate files and require them here.
// All of the Node.js APIs are available in the preload process.
// It has the same sandbox as a Chrome extension.
window.addEventListener('DOMContentLoaded', () => {
const replaceText = (selector, text) => {
const element = document.getElementById(selector)
if (element) element.innerText = text
}
for (const type of ['chrome', 'node', 'electron']) {
replaceText(`${type}-version`, process.versions[type])
}
})
// This file is required by the index.html file and will
// be executed in the renderer process for that window.
// No Node.js APIs are available in this process because
// `nodeIntegration` is turned off. Use `preload.js` to
// selectively enable features needed in the rendering
// process.
/* styles.css */
/* Add styles here to customize the appearance of your app */
@aaronkollasch
Copy link
Author

Steps to reproduce:

  • In System Preferences, set keyboard shortcuts to use Cmd-Left and Cmd-Right
  • Use this main.js file with https://github.com/electron/electron-quick-start
  • Try pressing Cmd+Shift+Left and Cmd+Shift+Right. The MenuItems will respond and print CursorHomeSelect and CursorEndSelect to stdout. However, the DevTools console will not log that key combination.

This appears to be a Chromium issue, as running this code in Chromium's DevTools:
window.addEventListener('keydown', (e) => {console.log(e);});
does not report Cmd+Shift+Left and Cmd+Shift+Right in Chromium, while it works fine in Firefox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment