Skip to content

Instantly share code, notes, and snippets.

@gogumai
Last active January 3, 2018 18:12
Show Gist options
  • Select an option

  • Save gogumai/706d75e0d78d0f44be6088f4c135d718 to your computer and use it in GitHub Desktop.

Select an option

Save gogumai/706d75e0d78d0f44be6088f4c135d718 to your computer and use it in GitHub Desktop.

Clean the utils and helpers folders

  1. Remove helpers/immutable.js: The ideal scenario would be to work always with immutable objects, so let's get rid of this helper :)
  2. Identify more improvements on those folders, check if code it's not being used, etc.

Move the corresponding components to a Page folder

Move the "pages" components to the Page folder. Naming convention: end file names with 'Page' postfix, eg. UsersPage.

Duck convention for naming action constants

Update to upperCase the last part of the constant
So instead of: export const GET_USER_ORG_USER_FETCHING = 'kaigi/all_users/get_user_org_user_fetching'
Do: export const GET_USER_ORG_USER_FETCHING = 'kaigi/all_users/GET_USER_ORG_USER_FETCHING'

Correct all linting issues

Fixing propTypes as well

Fix tests

Rename css folder to styles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment