Skip to content

Instantly share code, notes, and snippets.

@jlevy

jlevy/fetch_rejected_prs.py

Created December 3, 2025 04:54
Show Gist options

  • Select an option

    Learn more about clone URLs
  • Save jlevy/5720987753ca78e214f2ef8a4233bd67 to your computer and use it in GitHub Desktop.

Select an option

Learn more about clone URLs
Save jlevy/5720987753ca78e214f2ef8a4233bd67 to your computer and use it in GitHub Desktop.
Download ZIP
Fetch rejected PRs and maintainer feedback from GitHub repos
Raw
fetch_rejected_prs.py
#!/usr/bin/env -S uv run --script
# /// script
# requires-python = ">=3.11"
# dependencies = []
# ///
"""
Fetch rejected PRs and maintainer comments from a GitHub repo.
Uses `gh` CLI for authentication (must be logged in via `gh auth login`).
Usage:
uv run fetch_rejected_prs.py owner/repo [--limit N] [--output file.json]
Examples:
uv run fetch_rejected_prs.py Textualize/rich
uv run fetch_rejected_prs.py Textualize/rich --limit 50
uv run fetch_rejected_prs.py Textualize/rich --output rich_rejected.json
"""
from __future__ import annotations
import argparse
import json
import subprocess
import sys
from datetime import datetime
from pathlib import Path
from typing import Any
def gh_api(endpoint: str) -> dict[str, Any] | list[Any] | None:
"""Call GitHub API using gh CLI."""
try:
result = subprocess.run(
["gh", "api", endpoint],
capture_output=True,
text=True,
check=True,
)
return json.loads(result.stdout)
except subprocess.CalledProcessError as e:
print(f" API error: {e.stderr[:200]}", file=sys.stderr)
return None
except json.JSONDecodeError:
return None
def get_rejected_prs(owner: str, repo: str, limit: int) -> list[dict[str, Any]]:
"""Fetch closed PRs that were NOT merged (rejected)."""
rejected: list[dict[str, Any]] = []
page = 1
per_page = 100
while len(rejected) < limit:
print(f" Fetching PRs page {page}...")
endpoint = f"/repos/{owner}/{repo}/pulls?state=closed&page={page}&per_page={per_page}"
prs = gh_api(endpoint)
if not prs or not isinstance(prs, list):
break
for pr in prs:
if pr.get("merged_at") is None: # Not merged = rejected
rejected.append(pr)
if len(rejected) >= limit:
break
if len(prs) < per_page:
break
page += 1
return rejected
def get_pr_comments(owner: str, repo: str, pr_number: int) -> list[dict[str, Any]]:
"""Fetch all comments on a PR (issue comments + reviews)."""
comments: list[dict[str, Any]] = []
# Issue comments
issue_comments = gh_api(f"/repos/{owner}/{repo}/issues/{pr_number}/comments?per_page=100")
if issue_comments and isinstance(issue_comments, list):
for c in issue_comments:
c["type"] = "comment"
comments.extend(issue_comments)
# PR reviews with body
reviews = gh_api(f"/repos/{owner}/{repo}/pulls/{pr_number}/reviews?per_page=100")
if reviews and isinstance(reviews, list):
for r in reviews:
if r.get("body"):
comments.append({
"user": r["user"],
"body": r["body"],
"created_at": r.get("submitted_at"),
"author_association": r.get("author_association"),
"type": "review",
"review_state": r.get("state"),
})
return comments
def filter_maintainer_comments(
comments: list[dict[str, Any]], pr_author: str
) -> list[dict[str, Any]]:
"""Filter to maintainer/member comments only, excluding PR author."""
maintainer_roles = {"OWNER", "MEMBER", "COLLABORATOR"}
return [
{
"author": c.get("user", {}).get("login", ""),
"author_association": c.get("author_association", ""),
"body": c.get("body", ""),
"created_at": c.get("created_at"),
"type": c.get("type", "comment"),
"review_state": c.get("review_state"),
}
for c in comments
if c.get("author_association") in maintainer_roles
and c.get("user", {}).get("login") != pr_author
]
def main() -> None:
parser = argparse.ArgumentParser(
description="Fetch rejected PRs and maintainer feedback from GitHub"
)
parser.add_argument("repo", help="GitHub repo (owner/repo)")
parser.add_argument("--limit", type=int, default=100, help="max PRs to fetch (default: 100)")
parser.add_argument("--output", help="output file (default: {repo}_rejected_prs.json)")
args = parser.parse_args()
# Validate repo format
if "/" not in args.repo:
print(f"Error: repo must be in 'owner/repo' format, got: {args.repo}", file=sys.stderr)
sys.exit(1)
owner, repo = args.repo.split("/", 1)
output_path = Path(args.output or f"{repo}_rejected_prs.json")
# Check gh CLI auth
try:
subprocess.run(["gh", "auth", "status"], capture_output=True, check=True)
except (subprocess.CalledProcessError, FileNotFoundError):
print("Error: gh CLI not authenticated. Run: gh auth login", file=sys.stderr)
sys.exit(1)
print(f"Fetching rejected PRs from {owner}/{repo}...")
# Get rejected PRs
rejected_prs = get_rejected_prs(owner, repo, args.limit)
print(f" Found {len(rejected_prs)} rejected PRs")
# Collect maintainer feedback
results: list[dict[str, Any]] = []
for i, pr in enumerate(rejected_prs):
pr_number = pr["number"]
pr_title = pr["title"]
pr_author = pr["user"]["login"]
print(f" [{i + 1}/{len(rejected_prs)}] PR #{pr_number}: {pr_title[:50]}...")
comments = get_pr_comments(owner, repo, pr_number)
maintainer_comments = filter_maintainer_comments(comments, pr_author)
if maintainer_comments:
results.append({
"pr_number": pr_number,
"pr_title": pr_title,
"pr_url": pr["html_url"],
"pr_author": pr_author,
"created_at": pr["created_at"],
"closed_at": pr["closed_at"],
"maintainer_comments": maintainer_comments,
})
# Save results
output_path.write_text(json.dumps({
"repo": args.repo,
"fetched_at": datetime.now().isoformat(),
"total_rejected_prs": len(rejected_prs),
"prs_with_feedback": len(results),
"prs": results,
}, indent=2))
print(f"\nSaved {len(results)} PRs with maintainer feedback to {output_path}")
# Print sample
if results:
print("\n" + "=" * 60)
print("SAMPLE MAINTAINER FEEDBACK")
print("=" * 60)
for pr in results[:3]:
print(f"\n### PR #{pr['pr_number']}: {pr['pr_title']}")
print(f" {pr['pr_url']}")
for c in pr["maintainer_comments"][:2]:
state = f" [{c['review_state']}]" if c.get("review_state") else ""
print(f"\n [{c['author']}{state}]:")
body = c["body"].strip()[:300]
for line in body.split("\n")[:5]:
print(f" {line}")
if __name__ == "__main__":
main()
Raw
rich_all_rejected_prs.json
{
"repo": "Textualize/rich",
"fetched_at": "2025-12-02T20:42:22.792303",
"total_rejected_prs": 376,
"prs_with_feedback": 202,
"prs": [
{
"pr_number": 3872,
"pr_title": "Add demo showcase and contributor entry",
"pr_url": "https://github.com/Textualize/rich/pull/3872",
"pr_author": "yvoryk",
"created_at": "2025-10-22T05:10:34Z",
"closed_at": "2025-10-22T09:52:51Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Thanks, but we don't need this. There are other similar examples in the docs and under `python -m` commands.",
"created_at": "2025-10-22T09:52:51Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 3856,
"pr_title": "Add wrapper-demo.py to examples",
"pr_url": "https://github.com/Textualize/rich/pull/3856",
"pr_author": "EhsanLS",
"created_at": "2025-09-28T09:30:56Z",
"closed_at": "2025-09-28T09:42:03Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Thanks, but I don't think this adds much. Going to pass on this one.",
"created_at": "2025-09-28T09:42:03Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 3855,
"pr_title": "Fix duplicate height attribute in ConsoleOptions",
"pr_url": "https://github.com/Textualize/rich/pull/3855",
"pr_author": "sunnynguyen-ai",
"created_at": "2025-09-26T23:12:24Z",
"closed_at": "2025-09-28T09:43:21Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "This doesn't do anything useful.",
"created_at": "2025-09-28T09:43:22Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 3798,
"pr_title": "fixing with none rich colored text",
"pr_url": "https://github.com/Textualize/rich/pull/3798",
"pr_author": "tinker495",
"created_at": "2025-07-16T17:20:03Z",
"closed_at": "2025-07-16T18:59:23Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Let Rich generate escape sequences. But don't try and use them as input. If you have escape sequences you want to preserve, wrap them in `Text.from_ansi(my_string)`.",
"created_at": "2025-07-16T18:59:23Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 3770,
"pr_title": "fix(syntax): prevent clipping with syntax + padding",
"pr_url": "https://github.com/Textualize/rich/pull/3770",
"pr_author": "arkuhn",
"created_at": "2025-06-18T06:02:29Z",
"closed_at": "2025-06-23T16:21:45Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Thanks for the PR! I've gone with a slightly different approach in https://github.com/Textualize/rich/pull/3782",
"created_at": "2025-06-23T16:21:45Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 3759,
"pr_title": "Add option for custom animation frames when creating a Spinner",
"pr_url": "https://github.com/Textualize/rich/pull/3759",
"pr_author": "iamevn",
"created_at": "2025-06-12T18:36:09Z",
"closed_at": "2025-06-24T10:04:18Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "I'm afraid I'm not accepting new features, which could be implemented outside of the core library.",
"created_at": "2025-06-12T19:36:50Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 3756,
"pr_title": "Fix: spacing on arc spinner",
"pr_url": "https://github.com/Textualize/rich/pull/3756",
"pr_author": "bitplane",
"created_at": "2025-06-09T10:12:34Z",
"closed_at": "2025-06-24T10:09:48Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "That makes it looks worse for me. Terminals don't always agree with wcswidth. Getting it to work nicely everywhere is likely impossible I'm afraid. Thanks for trying.",
"created_at": "2025-06-24T10:09:48Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 3755,
"pr_title": "Private random generator for style link",
"pr_url": "https://github.com/Textualize/rich/pull/3755",
"pr_author": "MamoruDS",
"created_at": "2025-06-08T07:03:06Z",
"closed_at": "2025-06-24T10:17:21Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "I will need to understand what problem this solves for you. I suspect you will be better off using a random generator in your code, than modifying libraries.\r\n\r\nClosing for now, but re-open if you can elaborate further.",
"created_at": "2025-06-24T10:17:21Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 3737,
"pr_title": "README.md: Upgrade badge for Supported Python Versions",
"pr_url": "https://github.com/Textualize/rich/pull/3737",
"pr_author": "cclauss",
"created_at": "2025-05-19T14:23:30Z",
"closed_at": "2025-05-19T17:04:15Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Thanks. Went with Tom's PR. ",
"created_at": "2025-05-19T17:04:15Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "thanks",
"created_at": "2025-05-19T17:02:55Z",
"type": "review",
"review_state": "APPROVED"
}
]
},
{
"pr_number": 3710,
"pr_title": "Feature/indeterminate progress with elapsed",
"pr_url": "https://github.com/Textualize/rich/pull/3710",
"pr_author": "IAdityaKaushal",
"created_at": "2025-04-23T07:41:19Z",
"closed_at": "2025-06-24T12:53:23Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "There is way too much going on in this PR. There seems to be code unrelated to progress bars.\r\n\r\nAt this point, I can't accept new features. Especially if those features could be implemented outside of the core library.",
"created_at": "2025-06-24T12:53:23Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 3688,
"pr_title": "Fix/console buffering",
"pr_url": "https://github.com/Textualize/rich/pull/3688",
"pr_author": "shyam-ramani",
"created_at": "2025-04-02T08:07:32Z",
"closed_at": "2025-04-02T09:06:11Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Nothing needs fixing here.\r\n\r\nPlease, no LLM produced code, unless you fully understand what problem you are solving.",
"created_at": "2025-04-02T09:06:11Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 3687,
"pr_title": "Fix/terminal color support",
"pr_url": "https://github.com/Textualize/rich/pull/3687",
"pr_author": "shyam-ramani",
"created_at": "2025-04-02T08:00:17Z",
"closed_at": "2025-04-02T09:04:03Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "This doesn't fix anything.",
"created_at": "2025-04-02T09:04:03Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 3686,
"pr_title": "Fix table alignment with Unicode characters by adding proper width ca\u2026",
"pr_url": "https://github.com/Textualize/rich/pull/3686",
"pr_author": "shyam-ramani",
"created_at": "2025-04-02T07:50:26Z",
"closed_at": "2025-04-02T09:03:06Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Rich already handles double cell characters. Some emoji are never going to work because terminals render them at different widths, no matter what the unicodedata says.\r\n\r\nIf you are using an LLM to write this code, you should know that they tend to produce garbage.",
"created_at": "2025-04-02T09:03:06Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 3663,
"pr_title": "Debloat",
"pr_url": "https://github.com/Textualize/rich/pull/3663",
"pr_author": "abdeliibrahim",
"created_at": "2025-03-15T22:37:18Z",
"closed_at": "2025-03-16T10:52:01Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Thanks @darrenburns I've also blocked that user.",
"created_at": "2025-03-16T11:46:03Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 3654,
"pr_title": "Add Dockerfile for Rich project",
"pr_url": "https://github.com/Textualize/rich/pull/3654",
"pr_author": "ImMedved",
"created_at": "2025-03-11T16:53:12Z",
"closed_at": "2025-03-30T11:24:44Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "This is out of scope.",
"created_at": "2025-03-30T11:24:44Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 3622,
"pr_title": "Skip tests which are expected to fail with Python 3.14",
"pr_url": "https://github.com/Textualize/rich/pull/3622",
"pr_author": "befeleme",
"created_at": "2025-01-28T09:10:19Z",
"closed_at": "2025-10-09T08:50:07Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Thanks. The work was done in https://github.com/Textualize/rich/pull/3861",
"created_at": "2025-10-09T08:50:07Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 3462,
"pr_title": "Change return type of `Live`'s contextmanager to `Self`",
"pr_url": "https://github.com/Textualize/rich/pull/3462",
"pr_author": "patrick91",
"created_at": "2024-08-20T14:10:34Z",
"closed_at": "2024-09-30T14:19:40Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Looks that like was done in another PR!",
"created_at": "2024-09-30T14:19:40Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 3444,
"pr_title": "Line 660 in /rich/progress.py (small input validation bug)",
"pr_url": "https://github.com/Textualize/rich/pull/3444",
"pr_author": "novanexu",
"created_at": "2024-08-03T21:47:43Z",
"closed_at": "2024-08-26T15:36:39Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Why would `bar_width` receive a string? It is typed as an optional int.",
"created_at": "2024-08-04T12:37:26Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 3426,
"pr_title": "Add support for continuation indent and optimize divide_line",
"pr_url": "https://github.com/Textualize/rich/pull/3426",
"pr_author": "noahbkim",
"created_at": "2024-07-12T17:46:47Z",
"closed_at": "2024-07-26T15:59:54Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "There is a backlog that I'm slowly working through. But I will get to it.\r\n\r\nIt might help to understand a bit about why you need this. Is there precedence of this style of output?",
"created_at": "2024-07-25T19:26:10Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Sorry, I don't think I can accept this as a feature, unless I was sure there was enough support for it. \r\n\r\nOptimizations / refactor would be fine.\r\n\r\nhttps://textual.textualize.io/blog/2023/07/29/pull-requests-are-cake-or-puppies/",
"created_at": "2024-07-26T13:07:36Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 3418,
"pr_title": "Handle dataclasses with unitialized fields in pretty printing",
"pr_url": "https://github.com/Textualize/rich/pull/3418",
"pr_author": "CollinHeist",
"created_at": "2024-07-06T23:34:15Z",
"closed_at": "2024-08-26T16:02:20Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "This probably isn't the fix. It can give the false impression that the attribute exists. Better to omit it entirely IMO.",
"created_at": "2024-08-26T15:54:06Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Thanks, but I've gone with a slightly different solution... https://github.com/Textualize/rich/pull/3472",
"created_at": "2024-08-26T16:02:20Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 3396,
"pr_title": "Progress: Added an option to TimeRemainingColumn to estimate the speed using an exponential moving average",
"pr_url": "https://github.com/Textualize/rich/pull/3396",
"pr_author": "Akulen",
"created_at": "2024-06-25T09:00:50Z",
"closed_at": "2024-07-01T20:50:40Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Thanks, but I think this is best done as an external class, and not the core lib.\r\n\r\nhttps://textual.textualize.io/blog/2023/07/29/pull-requests-are-cake-or-puppies/",
"created_at": "2024-07-01T20:50:40Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 3394,
"pr_title": "Make it possible to override the representation function from the outside",
"pr_url": "https://github.com/Textualize/rich/pull/3394",
"pr_author": "danijar",
"created_at": "2024-06-20T16:14:27Z",
"closed_at": "2024-07-01T20:48:49Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Can't accept this I'm afraid. I'm assuming you want to monkey patch `get_repr`? \r\n\r\nMonkey patching isn't good API, but if you are comfortable with it, you could just do this:\r\n\r\n```python\r\nglobals()['repr'] = lambda obj: \"foo\"\r\n```\r\n\r\nThat said, I think the best approach right now would be to write a method that accepts your objects and returns a proxy with a `__rich_repr__`.",
"created_at": "2024-06-20T16:38:57Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 3389,
"pr_title": "2286 pep657 error code ranges in traceback",
"pr_url": "https://github.com/Textualize/rich/pull/3389",
"pr_author": "Gothingbop",
"created_at": "2024-06-17T14:04:41Z",
"closed_at": "2024-09-29T12:05:05Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Great in principle. \r\n\r\nI think we can improve on the styles a bit. And some of the information present in the ascii version doesn't seem to be styled.\r\n\r\nThis will also need to handle older Pythons.",
"created_at": "2024-07-01T20:48:27Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Thanks. Closed in favor of https://github.com/Textualize/rich/pull/3486",
"created_at": "2024-09-29T12:05:05Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 3342,
"pr_title": "Documentation Update - Projects using Rich",
"pr_url": "https://github.com/Textualize/rich/pull/3342",
"pr_author": "JaydenDownes",
"created_at": "2024-04-22T04:13:47Z",
"closed_at": "2024-07-01T20:33:57Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "I don't think this is required. We used to do this, but it resulted in many requests to add projects.",
"created_at": "2024-07-01T20:33:57Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 3338,
"pr_title": "Add enable_link_path option to tracebacks",
"pr_url": "https://github.com/Textualize/rich/pull/3338",
"pr_author": "bvolkmer",
"created_at": "2024-04-18T12:55:14Z",
"closed_at": "2024-07-01T20:32:20Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Most terminals will do this automatically.",
"created_at": "2024-07-01T20:32:20Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 3336,
"pr_title": "Remove margin from text lines in Jupyter HTML template",
"pr_url": "https://github.com/Textualize/rich/pull/3336",
"pr_author": "vladsavelyev",
"created_at": "2024-04-17T12:58:17Z",
"closed_at": "2024-07-01T20:30:36Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Every change to Jupyter support causes someone else to complain.\r\n\r\nClosing, but happy to reconsider if you can convince me this doesn't break on any of the Jupyter platforms (there are many).",
"created_at": "2024-07-01T20:30:36Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "I've practically given up on Jupyter formatting issues. The issue is reasonable, but I can't be certain any solution wont break some Jupyter platform somewhere. Happy to leave the issue, but any fix would have to be tested with a good number of \r\nJupter platforms.",
"created_at": "2024-07-01T20:59:05Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 3313,
"pr_title": "Update markdown.py",
"pr_url": "https://github.com/Textualize/rich/pull/3313",
"pr_author": "Rhythmicc",
"created_at": "2024-03-27T14:36:26Z",
"closed_at": "2024-08-26T15:13:26Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "I can't reproduce this. Assuming fixed.",
"created_at": "2024-07-01T20:13:31Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "So it is empty cells that is the issue? Could have used that in description!",
"created_at": "2024-07-01T21:03:32Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Thanks. Fixed in main.",
"created_at": "2024-08-26T15:13:26Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 3311,
"pr_title": "live: add \"tail\" vertical_overflow method",
"pr_url": "https://github.com/Textualize/rich/pull/3311",
"pr_author": "bretello",
"created_at": "2024-03-26T10:16:14Z",
"closed_at": "2024-07-01T20:06:16Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Im afraid I don't think this is a good idea. Consider Textual for such functionality.\r\n\r\nhttps://textual.textualize.io/blog/2023/07/29/pull-requests-are-cake-or-puppies/",
"created_at": "2024-07-01T20:06:16Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 3300,
"pr_title": "Bisect all the things!",
"pr_url": "https://github.com/Textualize/rich/pull/3300",
"pr_author": "rodrigogiraoserrao",
"created_at": "2024-03-07T17:46:41Z",
"closed_at": "2024-07-01T20:02:01Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Just discovered that bisect key was added in 3.10. \r\n\r\nHowever, I don't think we will need it. It will work with the tuples--no need to separate them.",
"created_at": "2024-03-10T15:30:34Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "No, its good. Just need to find the time to review.",
"created_at": "2024-03-25T11:45:47Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Going to break this out in to smaller changes.",
"created_at": "2024-07-01T20:02:01Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "I gather the `_cell_widths.py` change is for bisect. Could we keep the pairs and use `key=itemgetter(0)` with bisect?",
"created_at": "2024-03-08T13:02:06Z",
"type": "review",
"review_state": "COMMENTED"
}
]
},
{
"pr_number": 3294,
"pr_title": "Add the ability to disable the display of object attributes, or to only display selected attributes in the inspect function.",
"pr_url": "https://github.com/Textualize/rich/pull/3294",
"pr_author": "mateusz-wozny",
"created_at": "2024-02-29T08:54:36Z",
"closed_at": "2024-07-01T19:56:55Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "What has that many attributes?",
"created_at": "2024-07-01T19:55:12Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Closing, because I doubt this is a concern for anyone else. Willing to be convinced.",
"created_at": "2024-07-01T19:56:55Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 3291,
"pr_title": "feat: add blank lines in blockquote to adhere to MD standard",
"pr_url": "https://github.com/Textualize/rich/pull/3291",
"pr_author": "ollisco",
"created_at": "2024-02-27T19:29:40Z",
"closed_at": "2024-07-01T19:53:37Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Closing. Assumed stale. Feel free to reopen if it is still an issue.",
"created_at": "2024-07-01T19:53:37Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 3288,
"pr_title": "added terminal themes: solarized light/dark",
"pr_url": "https://github.com/Textualize/rich/pull/3288",
"pr_author": "isidroas",
"created_at": "2024-02-26T12:22:40Z",
"closed_at": "2024-07-01T19:52:38Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "I think these are best maintained in an independent package. Feel free to publish rich-terminal-themes.",
"created_at": "2024-07-01T19:52:38Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 3270,
"pr_title": "use larger width/height defaults for non-interactive consoles",
"pr_url": "https://github.com/Textualize/rich/pull/3270",
"pr_author": "ttarabula",
"created_at": "2024-02-02T18:21:18Z",
"closed_at": "2024-08-26T13:31:29Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "You can set the env var COLUMNS to your desired width when running non-interactively. Would that work for you?",
"created_at": "2024-07-01T19:40:21Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "This is a bad idea. You wouldn't want a rule or table to be 32767 characters long.",
"created_at": "2024-02-29T14:03:28Z",
"type": "review",
"review_state": "COMMENTED"
}
]
},
{
"pr_number": 3247,
"pr_title": "Added customization to the illegal_choice_message. ",
"pr_url": "https://github.com/Textualize/rich/pull/3247",
"pr_author": "SamuelMorrisProjects",
"created_at": "2024-01-05T20:43:49Z",
"closed_at": "2024-07-01T15:03:53Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "The recommended way to do this would be to subclass your Prompt class.",
"created_at": "2024-07-01T15:03:53Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 3242,
"pr_title": "Update progress.rst",
"pr_url": "https://github.com/Textualize/rich/pull/3242",
"pr_author": "vikasharma005",
"created_at": "2023-12-31T06:40:53Z",
"closed_at": "2024-07-01T15:01:30Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Thanks for the PR, added a note in master.",
"created_at": "2024-07-01T15:01:31Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 3241,
"pr_title": "Add new prompt classes for path inputs",
"pr_url": "https://github.com/Textualize/rich/pull/3241",
"pr_author": "miili",
"created_at": "2023-12-30T17:29:21Z",
"closed_at": "2024-07-01T14:50:26Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Looks good, but it doesn't need to be part of the core library.\r\n\r\nhttps://textual.textualize.io/blog/2023/07/29/pull-requests-are-cake-or-puppies/",
"created_at": "2024-07-01T14:50:26Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 3237,
"pr_title": "Add \"crop_top\" and \"ellipsis_top\" options for vertical overflow of live display",
"pr_url": "https://github.com/Textualize/rich/pull/3237",
"pr_author": "chillb0nes",
"created_at": "2023-12-25T20:25:20Z",
"closed_at": "2024-07-01T14:49:22Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "You're better of with Textual for this kind of thing...",
"created_at": "2024-07-01T14:49:22Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 3236,
"pr_title": "Make the Console generic on the file type",
"pr_url": "https://github.com/Textualize/rich/pull/3236",
"pr_author": "NeilGirdhar",
"created_at": "2023-12-22T02:28:12Z",
"closed_at": "2024-07-01T14:48:31Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "I suspect this will cause typing errors for anyone who doesn't provide the generic type. And that would lead to a flood of issues.\r\n\r\nThe solution is good, but for this reason I don't think I can merge.",
"created_at": "2024-07-01T14:48:31Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Errors or warnings, I'll still get issues. I think an isinstance check is the right thing to do here. Or you could use the capture API.",
"created_at": "2024-07-01T15:56:53Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 3233,
"pr_title": "fix(`BrokenPipeError`): fixes #1591",
"pr_url": "https://github.com/Textualize/rich/pull/3233",
"pr_author": "lmmx",
"created_at": "2023-12-16T13:58:05Z",
"closed_at": "2024-08-26T13:32:19Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "I think this is a good step forward, but I'm uncertain if this is the fix (or at least all of it). The [docs](https://docs.python.org/3/library/signal.html#note-on-sigpipe) suggest that this can happen on writes as well as flushes.\r\n\r\nIt also seems disruptive for a library to explicitly exit the app.\r\n\r\nMaybe there should be a method on Console that is called when a broken pip is received. The default behavior could raise an exception, but the dev could implement different behavior if desired.\r\n\r\nEither way, it should be documented.",
"created_at": "2024-07-01T14:45:23Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Closed in favor of https://github.com/Textualize/rich/pull/3468",
"created_at": "2024-08-26T13:32:19Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 3222,
"pr_title": "Mxp support",
"pr_url": "https://github.com/Textualize/rich/pull/3222",
"pr_author": "volundmush",
"created_at": "2023-12-03T17:51:36Z",
"closed_at": "2024-07-01T14:14:52Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Sorry, its just too niche to warrant going in the core library.\r\n\r\nhttps://textual.textualize.io/blog/2023/07/29/pull-requests-are-cake-or-puppies/",
"created_at": "2024-07-01T14:14:52Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 3218,
"pr_title": "Updating the example link used in downloader.py",
"pr_url": "https://github.com/Textualize/rich/pull/3218",
"pr_author": "LeileiChui",
"created_at": "2023-11-28T06:01:42Z",
"closed_at": "2024-07-01T14:12:21Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "That new link is out of date now. I need to come up with a better example link that won't expire.",
"created_at": "2024-07-01T14:12:21Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 3205,
"pr_title": "Update markdown.py",
"pr_url": "https://github.com/Textualize/rich/pull/3205",
"pr_author": "pop2pop3",
"created_at": "2023-11-17T10:15:18Z",
"closed_at": "2024-07-01T14:09:49Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Thanks. Updated in main, with revised wording.",
"created_at": "2024-07-01T14:09:50Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 3136,
"pr_title": "Style link id cache",
"pr_url": "https://github.com/Textualize/rich/pull/3136",
"pr_author": "rodrigogiraoserrao",
"created_at": "2023-09-26T12:39:41Z",
"closed_at": "2024-07-01T13:59:55Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "If you think it is a possible solution, please mark it as ready. We'll go over it at some point. Need to refresh my memory.",
"created_at": "2024-02-01T11:14:21Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "I don't quite grok this enough to merge. Closing for now, will look in to it again when I tackle the original issue.",
"created_at": "2024-07-01T13:59:55Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 3072,
"pr_title": "Modernize code",
"pr_url": "https://github.com/Textualize/rich/pull/3072",
"pr_author": "eumiro",
"created_at": "2023-08-01T20:29:40Z",
"closed_at": "2024-07-01T13:35:25Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Most of these changes are fairly arbitrary. Some may be worthwhile, but some its not clear what the benefit of the change is. Without knowing the issue they are fixing, its just not worth merging new code.\r\n\r\nI'd suggest separating the cosmetic changes, from larger changes, and submitting them separately.",
"created_at": "2024-07-01T13:35:25Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 3058,
"pr_title": "progress-bar-track",
"pr_url": "https://github.com/Textualize/rich/pull/3058",
"pr_author": "Vinnybrunn00",
"created_at": "2023-07-27T22:39:20Z",
"closed_at": "2024-07-01T13:31:11Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Examples should be fully-working, and use Python conventions (i.e. snake_case).\r\n\r\nClosing for now. Feel free to resubmit if you want to make those changes.",
"created_at": "2024-07-01T13:31:11Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 3056,
"pr_title": "Allow RichHandler to accept a 'style' attribute passed via LogRecord",
"pr_url": "https://github.com/Textualize/rich/pull/3056",
"pr_author": "koshell",
"created_at": "2023-07-26T19:44:44Z",
"closed_at": "2023-07-29T15:45:23Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "The Console object has a `style` argument which you can pass to the RichHandler.",
"created_at": "2023-07-29T15:45:23Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 3050,
"pr_title": "Trailing whitespace fixes",
"pr_url": "https://github.com/Textualize/rich/pull/3050",
"pr_author": "robinbowes",
"created_at": "2023-07-22T15:27:29Z",
"closed_at": "2024-07-01T13:24:58Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Thanks for the PR. Fixed in master.",
"created_at": "2024-07-01T13:24:58Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 3041,
"pr_title": "Added emojis from Emoji Versions 13,0, 13.1, 14.0 and 15.0",
"pr_url": "https://github.com/Textualize/rich/pull/3041",
"pr_author": "rly0nheart",
"created_at": "2023-07-20T04:13:27Z",
"closed_at": "2024-07-01T13:21:28Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Most terminals don't support or render these new emoji. I fear it would just disappoint most users.\r\n\r\nIf you do need those emoji, and they work on your terminal, you can always cut n paste.",
"created_at": "2024-07-01T13:21:28Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 3038,
"pr_title": "Make rich look better in legacy Windows Console",
"pr_url": "https://github.com/Textualize/rich/pull/3038",
"pr_author": "littlewhitecloud",
"created_at": "2023-07-18T12:01:57Z",
"closed_at": "2023-08-01T14:35:31Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "What does `os.system(\"\")` do? I'm assuming it enables virtual terminal sequences some how, but that is not something that Rich should do automatically, since it is a global setting. Can't you add that to your app?",
"created_at": "2023-07-18T12:44:36Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "I can't accept this, because it changes the state of the terminal as a side-effect of importing. This may impact other users who weren't accepting it.",
"created_at": "2023-08-01T14:35:31Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 3025,
"pr_title": "Fix tag RegEx",
"pr_url": "https://github.com/Textualize/rich/pull/3025",
"pr_author": "MicaelJarniac",
"created_at": "2023-07-05T23:37:03Z",
"closed_at": "2024-07-01T13:19:10Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "You're not always going to be able to parse things perfectly. REPRs aren't a formal grammar, and there will always be output which break it.\r\n\r\nHappy to accept a PR that improves on it though. One thing to be aware of is performance. You might print a lot of text with Rich, and overly expensive regexes can be a problem.",
"created_at": "2023-07-11T14:24:51Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Closing, assumed stale. But if you are still working on it, feel free to reopen.",
"created_at": "2024-07-01T13:19:10Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 3016,
"pr_title": "Added __lt__ function to Text class to enable sort functionality",
"pr_url": "https://github.com/Textualize/rich/pull/3016",
"pr_author": "sharkusk",
"created_at": "2023-07-02T22:06:10Z",
"closed_at": "2024-07-01T13:17:51Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Probably not needed now. The DataTable has grown more sorting functionality.",
"created_at": "2024-07-01T13:17:51Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 3015,
"pr_title": "Strip control codes in `Text.append_tokens`",
"pr_url": "https://github.com/Textualize/rich/pull/3015",
"pr_author": "hamdanal",
"created_at": "2023-07-02T11:10:09Z",
"closed_at": "2024-07-01T13:16:53Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "This appears to workaround the issue rather than fix it. It doesn't take in to account cell length.\r\n\r\nAppreciate the PR, but I think we will solve this a different way.",
"created_at": "2024-07-01T13:16:53Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 2996,
"pr_title": "Added `no_border` option to `console.print_exception`",
"pr_url": "https://github.com/Textualize/rich/pull/2996",
"pr_author": "t-mangoe",
"created_at": "2023-06-10T00:32:41Z",
"closed_at": "2024-07-01T13:13:52Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "There may be a need for a simpler output format, but no_border is too descriptive.\r\n\r\nA future release may have a switch that does this, and other changes.\r\n\r\nThanks for the PR.",
"created_at": "2024-07-01T13:13:52Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 2982,
"pr_title": "Added CustomHighlighter class to highlighter.py",
"pr_url": "https://github.com/Textualize/rich/pull/2982",
"pr_author": "EatenCheetos",
"created_at": "2023-06-01T00:14:10Z",
"closed_at": "2024-07-01T13:09:41Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Closing, assumed stale.",
"created_at": "2024-07-01T13:09:41Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 2976,
"pr_title": "Apply pyupgrade suggestions",
"pr_url": "https://github.com/Textualize/rich/pull/2976",
"pr_author": "DimitriPapadopoulos",
"created_at": "2023-05-31T12:47:19Z",
"closed_at": "2024-07-01T13:09:05Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Thanks. Applied pyupgrade to master.",
"created_at": "2024-07-01T13:09:06Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 2968,
"pr_title": "Tests adjustments needed for compatibility with Python 3.12",
"pr_url": "https://github.com/Textualize/rich/pull/2968",
"pr_author": "hrnciar",
"created_at": "2023-05-19T06:44:42Z",
"closed_at": "2024-07-01T12:54:23Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Assuming stale, tests are running on 3.12 now. Thanks for the PR.",
"created_at": "2024-07-01T12:54:23Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 2967,
"pr_title": "removed one stale line from console.log docstring",
"pr_url": "https://github.com/Textualize/rich/pull/2967",
"pr_author": "peppedilillo",
"created_at": "2023-05-18T22:01:36Z",
"closed_at": "2024-07-01T12:52:14Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Thanks, fixed in master.",
"created_at": "2024-07-01T12:52:14Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 2953,
"pr_title": "Leven alg",
"pr_url": "https://github.com/Textualize/rich/pull/2953",
"pr_author": "zhihengy",
"created_at": "2023-05-07T08:36:03Z",
"closed_at": "2023-07-29T15:54:03Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Clever, bit not something I'm willing to support.\r\n\r\nhttps://textual.textualize.io/blog/2023/07/29/pull-requests-are-cake-or-puppies/",
"created_at": "2023-07-29T15:54:03Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 2947,
"pr_title": "Fix: Raise MissingStyle error for invalid style when printing to console ",
"pr_url": "https://github.com/Textualize/rich/pull/2947",
"pr_author": "sunnyt02",
"created_at": "2023-05-01T20:12:12Z",
"closed_at": "2024-07-01T12:47:37Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Thanks for your PR. Closing, but see issue for rationale.",
"created_at": "2024-07-01T12:47:37Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 2937,
"pr_title": "Tweaked SVG generation to be more readable",
"pr_url": "https://github.com/Textualize/rich/pull/2937",
"pr_author": "evtn",
"created_at": "2023-04-26T17:03:28Z",
"closed_at": "2024-07-01T12:40:39Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "I\u2019m afraid I can\u2019t justify a new dependency, or the breaking change, without a very good reason.",
"created_at": "2023-04-26T18:19:04Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 2934,
"pr_title": "ensure threads are stopped in Progress().track",
"pr_url": "https://github.com/Textualize/rich/pull/2934",
"pr_author": "ThunderKey",
"created_at": "2023-04-25T09:17:41Z",
"closed_at": "2024-07-01T12:39:27Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Thanks, fixed in master (slightly different solution(",
"created_at": "2024-07-01T12:39:27Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 2916,
"pr_title": "Fix auto detection of terminal size on Windows",
"pr_url": "https://github.com/Textualize/rich/pull/2916",
"pr_author": "lewis-yeung",
"created_at": "2023-04-09T00:35:36Z",
"closed_at": "2024-07-01T11:53:08Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Closing, assumed stale. If it is still relevant, please open an issue with code to reproduce.",
"created_at": "2024-07-01T11:53:09Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 2905,
"pr_title": "Text.format() feature",
"pr_url": "https://github.com/Textualize/rich/pull/2905",
"pr_author": "pom11",
"created_at": "2023-03-27T08:51:21Z",
"closed_at": "2023-04-21T14:40:43Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "I'm afraid it doesn't work as expected.\r\n\r\n<img width=\"1219\" alt=\"Screenshot 2023-03-27 at 13 56 06\" src=\"https://user-images.githubusercontent.com/554369/227946162-221cae8c-ab51-44fc-a4ea-7015f9ceecba.png\">\r\n\r\nIt's a worthwhile feature, but it would require full understanding of the Text internals. We would also need comprehensive unit tests.",
"created_at": "2023-03-27T13:07:10Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Sorry, I'm afraid I can't merge this PR. I have a feeling the implementation is doing more work than it needs to be, and the overall code quality isn't quite high enough.\r\n\r\nThe tests don't give me any confidence in the code. Test should be treated almost like documentation, with a function for each aspect of the code being tested. It's not enough just to get full converage.\r\n\r\nIf you need this, you might want to factor it out in to your own code. Keep it as an external function rather than a method in the core lib.",
"created_at": "2023-04-21T14:40:43Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "The efficiency of this method could be improved.\r\n\r\nReadability could use some work. Better named variables etc. `str_index` says what it is, but doesn't say what it is used for. We have a no abbreviation and no single letter variables (with a few exceptions).\r\n\r\nA few well-placed comments would also help to follow the code.\r\n\r\nWe will need a lot more tests before this could be merged.",
"created_at": "2023-03-28T11:10:32Z",
"type": "review",
"review_state": "CHANGES_REQUESTED"
}
]
},
{
"pr_number": 2891,
"pr_title": "fix: bug: python REPL evaluated result ignores custom highlighter",
"pr_url": "https://github.com/Textualize/rich/pull/2891",
"pr_author": "xsjk",
"created_at": "2023-03-22T14:33:25Z",
"closed_at": "2024-07-01T11:49:52Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "I don't think it makes sense for pretty prints to respect these parameters. If you do need it, then you can construct a Pretty instance manually.",
"created_at": "2024-07-01T11:49:52Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 2889,
"pr_title": "fix: bug: IPython environment undetection in `pretty.install()`",
"pr_url": "https://github.com/Textualize/rich/pull/2889",
"pr_author": "xsjk",
"created_at": "2023-03-21T19:25:58Z",
"closed_at": "2024-07-01T11:44:43Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Closing, assumed stale.",
"created_at": "2024-07-01T11:44:43Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 2884,
"pr_title": "expand requirements",
"pr_url": "https://github.com/Textualize/rich/pull/2884",
"pr_author": "ucodery",
"created_at": "2023-03-20T17:22:12Z",
"closed_at": "2024-07-01T11:43:42Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "I don't think this is needed. Requirements for one-off tools used mostly internally, don't warrant inclusion in dev dependancies. It increases the risk of conflicts.",
"created_at": "2024-07-01T11:43:42Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 2876,
"pr_title": "adding syntax column_offset",
"pr_url": "https://github.com/Textualize/rich/pull/2876",
"pr_author": "Ayehavgunne",
"created_at": "2023-03-13T13:32:32Z",
"closed_at": "2024-07-01T11:46:19Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "I'm afraid I don't understand what problem this is solving. Can you give me an example of the output this generates?",
"created_at": "2024-07-01T11:41:10Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 2873,
"pr_title": "use object.__new__(Style) consistently",
"pr_url": "https://github.com/Textualize/rich/pull/2873",
"pr_author": "The-Alchemist",
"created_at": "2023-03-11T16:56:10Z",
"closed_at": "2024-07-01T11:10:41Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Doesn't seem relevant now.",
"created_at": "2024-07-01T11:10:41Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 2871,
"pr_title": "Add 2 new spinners: an egg hatching and a rocket going to space",
"pr_url": "https://github.com/Textualize/rich/pull/2871",
"pr_author": "vemonet",
"created_at": "2023-03-10T10:31:32Z",
"closed_at": "2024-07-01T10:58:19Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "I can't accept new spinners atm. But I would consider a mechanism to make it easier to create custom spinners.",
"created_at": "2024-07-01T10:58:19Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 2854,
"pr_title": "gh: refactor community files",
"pr_url": "https://github.com/Textualize/rich/pull/2854",
"pr_author": "SauravMaheshkar",
"created_at": "2023-03-04T16:48:27Z",
"closed_at": "2023-03-04T16:58:07Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "All this will accomplish is reducing visibility for those files.",
"created_at": "2023-03-04T16:58:07Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 2811,
"pr_title": "Improve Traceback Frame Suppression",
"pr_url": "https://github.com/Textualize/rich/pull/2811",
"pr_author": "debanjum",
"created_at": "2023-02-15T21:11:19Z",
"closed_at": "2023-03-04T15:30:34Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "I'm not keen on the regex approach. The chances are too high that you end up excluding something accidentally. I'd consider callbacks or some other protocol to do this.",
"created_at": "2023-03-04T15:30:34Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 2774,
"pr_title": "fix: bump dependency on pygments to ^2.14.0",
"pr_url": "https://github.com/Textualize/rich/pull/2774",
"pr_author": "sandrotosi",
"created_at": "2023-01-25T04:25:55Z",
"closed_at": "2023-01-27T17:05:35Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Thanks. Done in https://github.com/Textualize/rich/pull/2783",
"created_at": "2023-01-27T17:05:35Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 2759,
"pr_title": "Let rich.pretty.install support ptpython, fix #2749",
"pr_url": "https://github.com/Textualize/rich/pull/2759",
"pr_author": "Freed-Wu",
"created_at": "2023-01-17T13:16:12Z",
"closed_at": "2023-01-27T16:09:18Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "I don't think I can accept this. There needs to be a better mechanism that try all possible libraries until one works. Perhaps Rich is not the right place for this code.",
"created_at": "2023-01-27T16:09:18Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 2756,
"pr_title": "Improve grammar in documentation",
"pr_url": "https://github.com/Textualize/rich/pull/2756",
"pr_author": "ssbarnea",
"created_at": "2023-01-14T12:30:29Z",
"closed_at": "2023-01-15T22:27:53Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "The FAQ is auto-generated by Faqtory, so pointless to edit. Not going to edit a standard COC. Don't agree with the majority of the remaining edits.",
"created_at": "2023-01-15T22:27:53Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 2752,
"pr_title": "Fix parsing of style definitions that contain color definitions with spaces",
"pr_url": "https://github.com/Textualize/rich/pull/2752",
"pr_author": "IsaacBreen",
"created_at": "2023-01-14T08:24:31Z",
"closed_at": "2024-08-26T13:30:23Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Seems reasonable, and tests are passing. But there may be unintended consequences.\r\n\r\nConsider this:\r\n\r\n```python\r\nColor.parse(\"rgb(0,0,0)\") == Color.parse(\"rgb(0,0, 0)\")\r\n```\r\n\r\nThat is False with this update. Suggest we need to normalise the color name.",
"created_at": "2023-01-27T16:29:33Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "I'll need some tests to merge this.\r\n\r\n@IsaacBreen I know its been a while. Let me know if you still want to work on this.",
"created_at": "2024-07-01T10:22:25Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Closing, assumed stale. Feel free to reopen if you still want to work on this.",
"created_at": "2024-08-26T13:30:23Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 2751,
"pr_title": "tests: Adjustments to run tests with pygments 2.14.0",
"pr_url": "https://github.com/Textualize/rich/pull/2751",
"pr_author": "tijuca",
"created_at": "2023-01-14T06:57:21Z",
"closed_at": "2023-01-27T17:07:46Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Fix in next release",
"created_at": "2023-01-27T17:07:46Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 2746,
"pr_title": "Fix Panel logic for selecting priority of title/subtitle styling ",
"pr_url": "https://github.com/Textualize/rich/pull/2746",
"pr_author": "noprobelm",
"created_at": "2023-01-11T23:01:40Z",
"closed_at": "2024-07-01T10:41:57Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "There is a fix for this in main.",
"created_at": "2024-07-01T10:41:57Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 2741,
"pr_title": "Capture output goes to terminal by default",
"pr_url": "https://github.com/Textualize/rich/pull/2741",
"pr_author": "tinvaan",
"created_at": "2023-01-10T21:14:48Z",
"closed_at": "2023-01-27T16:36:46Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "There are other considerations you may not be aware of. You might want to leave this one to us.",
"created_at": "2023-01-17T11:51:30Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 2723,
"pr_title": "Add support for `pipx run rich`",
"pr_url": "https://github.com/Textualize/rich/pull/2723",
"pr_author": "cjolowicz",
"created_at": "2022-12-29T11:38:48Z",
"closed_at": "2023-01-27T20:25:49Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "I fear it might cause a little confusion. And I\u2019m not aware of folk have much difficulty in running the demo, so I\u2019m going to pass.\r\n\r\nBut thanks for educating me on these pips entry points!",
"created_at": "2023-01-27T20:25:49Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 2687,
"pr_title": "Bug fix 2686",
"pr_url": "https://github.com/Textualize/rich/pull/2687",
"pr_author": "SertugF",
"created_at": "2022-12-06T01:51:10Z",
"closed_at": "2022-12-06T07:34:26Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "See the issue for a different solution.",
"created_at": "2022-12-06T07:34:23Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 2608,
"pr_title": "chore: Update outdated LICENSE year",
"pr_url": "https://github.com/Textualize/rich/pull/2608",
"pr_author": "bluzir",
"created_at": "2022-10-25T08:22:05Z",
"closed_at": "2022-10-25T10:01:42Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Thanks but https://hynek.me/til/copyright-years/",
"created_at": "2022-10-25T10:01:42Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 2605,
"pr_title": "Add information about styleze range",
"pr_url": "https://github.com/Textualize/rich/pull/2605",
"pr_author": "Bernardoow",
"created_at": "2022-10-22T21:22:01Z",
"closed_at": "2023-03-04T09:23:24Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Thanks. +1 for the docs but I think we need to word it in a similar style to the rest of the doc.\r\n\r\nhttps://github.com/Textualize/rich/issues/2842",
"created_at": "2023-03-04T09:23:24Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 2555,
"pr_title": "feat(_spinners): add more spinners",
"pr_url": "https://github.com/Textualize/rich/pull/2555",
"pr_author": "wizard-28",
"created_at": "2022-10-01T06:07:49Z",
"closed_at": "2023-03-04T15:34:24Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "These are cool, but I suspect a number of these emojis will break on some terminals. ",
"created_at": "2023-03-04T15:34:24Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 2554,
"pr_title": "Implement Text comparator methods; fix Text equality checking; implement Text hashing for use as dict keys",
"pr_url": "https://github.com/Textualize/rich/pull/2554",
"pr_author": "michelcrypt4d4mus",
"created_at": "2022-10-01T05:21:15Z",
"closed_at": "2022-10-01T07:59:27Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Text objects are mutable, which makes them unsuitable for use as dictionary keys.\r\n\r\nI don't know if the `__eq__` was a fix or not. It's not clear if anything was broken. There are a number of attributes not included in the comparison, which suggests the current version is fine. Without a clear bug to fix, this is a somewhat arbitrary change, more likely to break other projects.\r\n\r\nThe `lt` change allows you to sort things. But why would you expect that to be the order? What problem is being solved?\r\n\r\nAppreciate the effort, but I can't merge this. If you would like to contribute, I'd suggesting picking a bug and focusing your efforts on fixing that.",
"created_at": "2022-10-01T07:59:27Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Neat project! Are you familiar with the key argument to sort and sorted functions? ",
"created_at": "2022-10-01T21:45:50Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 2520,
"pr_title": "Added console named argument to rich.reconfigure.",
"pr_url": "https://github.com/Textualize/rich/pull/2520",
"pr_author": "AndreasBackx",
"created_at": "2022-09-12T13:34:36Z",
"closed_at": "2022-09-20T10:25:01Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "The `console` arg was a mistake and was removed.\r\n\r\nI don't think you'll need it. You might want to open a discussion with your log render issues. There are probably better ways of solving it.",
"created_at": "2022-09-20T10:25:01Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 2511,
"pr_title": "CI pre-commit check",
"pr_url": "https://github.com/Textualize/rich/pull/2511",
"pr_author": "calumy",
"created_at": "2022-09-04T10:43:13Z",
"closed_at": "2023-03-04T11:09:20Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "https://github.com/Textualize/rich/issues/2849",
"created_at": "2023-03-04T11:09:20Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 2509,
"pr_title": "Update links to current repo",
"pr_url": "https://github.com/Textualize/rich/pull/2509",
"pr_author": "calumy",
"created_at": "2022-09-03T23:49:19Z",
"closed_at": "2022-09-19T10:35:44Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Thanks for pointing this out. Closing in favor of https://github.com/Textualize/rich/pull/2528",
"created_at": "2022-09-19T10:35:44Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 2500,
"pr_title": "Add option to suppress provided types in tracebacks",
"pr_url": "https://github.com/Textualize/rich/pull/2500",
"pr_author": "cmckain",
"created_at": "2022-08-31T04:39:37Z",
"closed_at": "2022-09-19T10:22:20Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Name (suppress_locals) and type (i.e. Any) isn't great. Also not convinced of the utility of omitting particular types.\r\n\r\nDon't think this is the solution. Willing to be convinved.",
"created_at": "2022-09-19T10:22:20Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "I think `Iterable[type]` works...\r\n\r\nI'm sympathetic to your use case, but it may be too difficult to satisfy everyone with an extra parameter. In that situation I usually prefer to expose hooks so that a user could implement their own particular requirements.",
"created_at": "2022-09-19T10:54:09Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 2448,
"pr_title": "Add a renderable that transforms text in \"child\" renderables, add transform-specific versions",
"pr_url": "https://github.com/Textualize/rich/pull/2448",
"pr_author": "davep",
"created_at": "2022-08-05T08:48:58Z",
"closed_at": "2022-08-12T14:25:36Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Looks good to me. \ud83d\udc4d ",
"created_at": "2022-08-06T08:20:24Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Very minor requests.\r\n\r\nCheck CI in a minute or two...",
"created_at": "2022-08-05T09:00:33Z",
"type": "review",
"review_state": "CHANGES_REQUESTED"
}
]
},
{
"pr_number": 2446,
"pr_title": "Add crosshairs feature",
"pr_url": "https://github.com/Textualize/rich/pull/2446",
"pr_author": "rodrigogiraoserrao",
"created_at": "2022-08-04T14:13:11Z",
"closed_at": "2022-08-17T13:54:56Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "That seems a very good way of expressing the test expectations. It's nice to be able to visually compare.\r\n\r\nI think, yes the crosshairs should have trailing whitespace.\r\n\r\nBTW, sorry to add this late in the day, but the crosshair class should take a `StyleType` so you can tweak the colors of the background / foreground.",
"created_at": "2022-08-04T14:24:45Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "It's fine not to use `options`. Not all renderables require it.\r\n\r\nRe testing the ANSI codes. You could test at a slightly higher level. Perhaps test the Segment objects have the expected Style. Converting Styles to ANSI codes has been so thoroughly tested there probably isn't any benefit in test that again.",
"created_at": "2022-08-06T08:13:19Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Thanks! Will do a review shortly.",
"created_at": "2022-08-06T08:23:59Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "LGTM. Nice efficient solution!",
"created_at": "2022-08-06T13:58:30Z",
"type": "review",
"review_state": "APPROVED"
}
]
},
{
"pr_number": 2433,
"pr_title": "Prompt messages",
"pr_url": "https://github.com/Textualize/rich/pull/2433",
"pr_author": "sdelliot",
"created_at": "2022-08-01T00:15:33Z",
"closed_at": "2022-09-19T10:13:00Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Saves a line or two at the expense of supporting additional parameters. Don't think its worth it.",
"created_at": "2022-09-19T10:13:00Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 2428,
"pr_title": "Bump attrs from 21.4.0 to 22.1.0",
"pr_url": "https://github.com/Textualize/rich/pull/2428",
"pr_author": "dependabot[bot]",
"created_at": "2022-07-29T13:40:54Z",
"closed_at": "2022-12-21T13:14:05Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "@dependabot rebase",
"created_at": "2022-09-19T10:10:53Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 2414,
"pr_title": "Provide `exclude_locals` mechanism to exclude certain regex patterns from Traceback output ",
"pr_url": "https://github.com/Textualize/rich/pull/2414",
"pr_author": "datajoely",
"created_at": "2022-07-21T18:56:59Z",
"closed_at": "2022-09-19T10:08:15Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Closing, assumed stale.",
"created_at": "2022-09-19T10:08:15Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "I think the redacted locals has to be recursive, which means it should be a feature of the `rich.retty` module.\r\n\r\nThis is tricker code than it might appear because Rich has to be extremely defensive. We can't risk the exception output generating an error of its own.\r\n\r\nI think this is a worthwhile feature, so I'd probably put it on the todo list regardless. But you are welcome to persevere!\r\n",
"created_at": "2022-07-22T15:23:32Z",
"type": "review",
"review_state": "CHANGES_REQUESTED"
}
]
},
{
"pr_number": 2405,
"pr_title": "Populate table using from_dict",
"pr_url": "https://github.com/Textualize/rich/pull/2405",
"pr_author": "Noble-47",
"created_at": "2022-07-18T21:56:05Z",
"closed_at": "2022-07-22T15:45:10Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Sorry, the interface for this `from_dict` doesn't gel well with the rest of the API. Good effort though. Perhaps you could make this a standalone project?",
"created_at": "2022-07-22T15:45:10Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 2396,
"pr_title": "Add optional 'spacer' argument to Spinner",
"pr_url": "https://github.com/Textualize/rich/pull/2396",
"pr_author": "brechtm",
"created_at": "2022-07-14T19:10:22Z",
"closed_at": "2022-09-19T10:02:32Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Not convinced this is necessary. If the spacing is not consistent, then perhaps that should be addressed. But I don't think it needs to be an option.\r\n\r\nClosing because I'm clearing the backlog. Re-open if you want to discuss further.",
"created_at": "2022-09-19T10:02:32Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "If your spacer argument makes it look a little better on your platform, at the expense of it breaking on another, then I would't want to add it.\r\n\r\nIf you can show me that it doesn't visually break on Mac, Windows, and Linux, I'll reconsider...",
"created_at": "2022-09-19T10:45:07Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "And if you change it from the default you break another platform. Which will be the case if the spinners were crafted with the space in mind.",
"created_at": "2022-09-19T11:01:34Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 2388,
"pr_title": "Allow for formatting cell-by-cell",
"pr_url": "https://github.com/Textualize/rich/pull/2388",
"pr_author": "wtareid",
"created_at": "2022-07-13T07:51:38Z",
"closed_at": "2022-09-19T09:59:08Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Can you please elaborate on what these change do?",
"created_at": "2022-07-22T15:50:07Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Closed, assumed stale.",
"created_at": "2022-09-19T09:59:08Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 2383,
"pr_title": "\ud83d\udc1b Fix type annotations for `@group` decorator",
"pr_url": "https://github.com/Textualize/rich/pull/2383",
"pr_author": "tiangolo",
"created_at": "2022-07-09T01:28:33Z",
"closed_at": "2023-03-04T11:06:18Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Thanks. I think we might tackle this as part of a larger review of typing. https://github.com/Textualize/rich/issues/2846",
"created_at": "2023-03-04T11:06:18Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 2364,
"pr_title": "logging render_message: Use message as-is if already Text",
"pr_url": "https://github.com/Textualize/rich/pull/2364",
"pr_author": "jevinskie",
"created_at": "2022-06-27T15:49:50Z",
"closed_at": "2022-06-27T17:40:53Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "The hexdump is *very* cool, but I'm afraid this is an abuse of logging. Logging may be configured to go to multiple destinations. If you log a Text object it will break with anything other than RichHandler.\r\n\r\nConsider using `console.log` which will give you similar results, and will already work with Text objects, but doesn't have the same limitations as logging",
"created_at": "2022-06-27T17:20:21Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 2347,
"pr_title": "Add `echo` param to `Console.capture`",
"pr_url": "https://github.com/Textualize/rich/pull/2347",
"pr_author": "darrenburns",
"created_at": "2022-06-16T11:54:06Z",
"closed_at": "2025-08-27T12:23:04Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Can update the docs to describe the new `echo` param please.",
"created_at": "2022-06-17T10:44:58Z",
"type": "review",
"review_state": "CHANGES_REQUESTED"
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "A few requests.",
"created_at": "2022-06-22T10:23:46Z",
"type": "review",
"review_state": "CHANGES_REQUESTED"
}
]
},
{
"pr_number": 2345,
"pr_title": "Progress: Add .get_task_elapsed(TaskID)",
"pr_url": "https://github.com/Textualize/rich/pull/2345",
"pr_author": "staehle",
"created_at": "2022-06-15T16:17:30Z",
"closed_at": "2022-09-19T09:54:14Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "A test is *always* necessary, I'm afraid!",
"created_at": "2022-06-17T10:42:05Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Closed, assumed stale. ",
"created_at": "2022-09-19T09:54:14Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 2321,
"pr_title": "Bump sphinx from 4.5.0 to 5.0.1",
"pr_url": "https://github.com/Textualize/rich/pull/2321",
"pr_author": "dependabot[bot]",
"created_at": "2022-06-03T13:25:48Z",
"closed_at": "2022-06-17T10:08:32Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "@dependabot rebase",
"created_at": "2022-06-17T10:07:58Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 2314,
"pr_title": "Add `rqdm` and `rrange` utilities for easy nested progress bars",
"pr_url": "https://github.com/Textualize/rich/pull/2314",
"pr_author": "nik-sm",
"created_at": "2022-06-01T05:16:19Z",
"closed_at": "2022-09-19T09:52:47Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Sorry, naming leaves a lot to be desired. Not sold on the functionality. Willing to be convinced.",
"created_at": "2022-09-19T09:52:47Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 2302,
"pr_title": "Add support to control pytest test, verbosity and coverage",
"pr_url": "https://github.com/Textualize/rich/pull/2302",
"pr_author": "tomers",
"created_at": "2022-05-26T19:12:51Z",
"closed_at": "2022-06-14T08:34:46Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Doesn't seem like much of an improvement over copying the command. And it's not very discoverable. Thanks anyway.",
"created_at": "2022-06-14T08:34:46Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 2270,
"pr_title": "[console][typing] Extract color-system-as-a-string to a type literal",
"pr_url": "https://github.com/Textualize/rich/pull/2270",
"pr_author": "olivierphi",
"created_at": "2022-05-11T10:21:37Z",
"closed_at": "2022-05-11T12:50:39Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "I'm not convinced this is worthwhile (see comments)\r\n\r\nI'd suggest moving the burden back to Textual. Defining a literal there, but bear in mind it is for internal use. I.e. The user will be unlikely to see this.",
"created_at": "2022-05-11T12:43:08Z",
"type": "review",
"review_state": "CHANGES_REQUESTED"
}
]
},
{
"pr_number": 2267,
"pr_title": "add tests for multiline reprs",
"pr_url": "https://github.com/Textualize/rich/pull/2267",
"pr_author": "rodrigogiraoserrao",
"created_at": "2022-05-09T22:38:06Z",
"closed_at": "2024-04-08T12:07:50Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "It's probably not necessary to test every container, as long as the system is well-tests.\r\n\r\nThe coverage calculation is quite flakey. It always seems to be off!",
"created_at": "2022-05-15T11:44:13Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "I think `_Line` being private, I can relax my pedantry a bit. But equally open to a better name if you can think of one!",
"created_at": "2022-06-14T08:47:00Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "@rodrigogiraoserrao Is this stale?",
"created_at": "2022-09-19T09:50:19Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "No hurry",
"created_at": "2022-09-19T09:54:28Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 2259,
"pr_title": "chore: Included githubactions in the dependabot config",
"pr_url": "https://github.com/Textualize/rich/pull/2259",
"pr_author": "naveensrinivasan",
"created_at": "2022-05-06T01:02:47Z",
"closed_at": "2022-09-19T09:49:28Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Don't understand this one. If you think its needed please reopen with a tl;dr explanation.",
"created_at": "2022-09-19T09:49:28Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 2253,
"pr_title": "Support pyinstaller relative paths in Traceback (#2251)",
"pr_url": "https://github.com/Textualize/rich/pull/2253",
"pr_author": "gormaniac",
"created_at": "2022-05-04T20:10:46Z",
"closed_at": "2022-09-19T09:46:49Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Closing. Assumed stale. Feel free to reopen if you want to continue work on it.",
"created_at": "2022-09-19T09:46:49Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 2244,
"pr_title": "Respect dim style on SVG export",
"pr_url": "https://github.com/Textualize/rich/pull/2244",
"pr_author": "sebslight",
"created_at": "2022-05-03T07:12:39Z",
"closed_at": "2022-05-03T07:17:23Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Thanks, but we're rewriting the SVG export functionality.",
"created_at": "2022-05-03T07:17:23Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 2232,
"pr_title": "Add level_width and level_format params to RichHandler",
"pr_url": "https://github.com/Textualize/rich/pull/2232",
"pr_author": "arthurlm",
"created_at": "2022-04-28T08:25:47Z",
"closed_at": "2022-05-03T10:10:52Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Sorry, the logging handler is too complex already. I can't accept new parameters. If you need this for a project I guess you wouldn't have much difficulty extending it in your own code. THanks anyway.",
"created_at": "2022-05-03T10:10:52Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 2227,
"pr_title": "Return a Task object from add_task, not an id",
"pr_url": "https://github.com/Textualize/rich/pull/2227",
"pr_author": "t-mart",
"created_at": "2022-04-26T13:40:39Z",
"closed_at": "2022-05-03T10:27:19Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Since this is a breaking change I couldn't accept it unless there was a very compelling reason to do so.\r\n\r\nExposing the Task object is probably a bad idea because there are some internal attributes there, that a user might expect to modify and have a meaningful effect.\r\n\r\nWhat might work is having an object that wraps TaskID and adds public methods. But this object would have not break the current API. i.e. `progress.update(my_task, ...` should continue to work in addition to `my_task.update(`.\r\n\r\nI'm going to close this PR, but happy to continue the discussion on Discussions tab.",
"created_at": "2022-05-03T10:27:19Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 2220,
"pr_title": "Bump pygments from 2.11.2 to 2.12.0",
"pr_url": "https://github.com/Textualize/rich/pull/2220",
"pr_author": "dependabot[bot]",
"created_at": "2022-04-25T13:35:51Z",
"closed_at": "2022-05-03T10:28:37Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "@dependabot rebase",
"created_at": "2022-05-03T10:28:27Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 2205,
"pr_title": "Fix documentaion to show how to use progress bars with open files #2204",
"pr_url": "https://github.com/Textualize/rich/pull/2205",
"pr_author": "hwmrocker",
"created_at": "2022-04-20T14:20:27Z",
"closed_at": "2022-04-21T08:33:32Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Thanks, but we've updated the progress docs to reflect the API change.",
"created_at": "2022-04-21T08:33:32Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 2192,
"pr_title": "Add support for a \"fuzzy\" choice matcher",
"pr_url": "https://github.com/Textualize/rich/pull/2192",
"pr_author": "azeemba",
"created_at": "2022-04-14T04:08:26Z",
"closed_at": "2022-04-14T15:40:16Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "This is a good idea, but probably not something that belongs in the core. It's easy enough to add to your project should you need it.",
"created_at": "2022-04-14T15:40:13Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 2182,
"pr_title": "Fix import of OrderedDict on Python <3.9",
"pr_url": "https://github.com/Textualize/rich/pull/2182",
"pr_author": "Dreamsorcerer",
"created_at": "2022-04-10T00:31:37Z",
"closed_at": "2022-04-10T06:20:00Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Fixed in 12.2.0",
"created_at": "2022-04-10T06:20:00Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 2178,
"pr_title": "Update Progress documentation",
"pr_url": "https://github.com/Textualize/rich/pull/2178",
"pr_author": "xqm32",
"created_at": "2022-04-08T06:45:58Z",
"closed_at": "2022-04-21T08:40:06Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "That doesn't read well...",
"created_at": "2022-04-11T07:22:31Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "No worries. I'll update the docs. \u8c22\u8c22\u4f60",
"created_at": "2022-04-12T06:57:39Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "I've updated the progress docs. Thanks for raising this.",
"created_at": "2022-04-21T08:40:06Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 2167,
"pr_title": "\u5f00\u7aef",
"pr_url": "https://github.com/Textualize/rich/pull/2167",
"pr_author": "vio-let-m",
"created_at": "2022-04-05T12:56:56Z",
"closed_at": "2022-04-06T10:02:11Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "I'm assuming this was a mistake?",
"created_at": "2022-04-06T10:02:11Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 2143,
"pr_title": "feat: waves spinner",
"pr_url": "https://github.com/Textualize/rich/pull/2143",
"pr_author": "H999",
"created_at": "2022-04-02T02:00:24Z",
"closed_at": "2022-04-14T15:41:57Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Sorry, can't accept code which runs at import time. This may have to remain something you could add to your own project, if you want it. But probably doesn't belong in the core lib.",
"created_at": "2022-04-14T15:41:57Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 2122,
"pr_title": "Allow default Console parameters to be configured with environment variables",
"pr_url": "https://github.com/Textualize/rich/pull/2122",
"pr_author": "joouha",
"created_at": "2022-03-27T17:07:51Z",
"closed_at": "2022-09-19T09:46:11Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "I'm not keen on adding env vars that aren't already a standard. As a library, Rich shouldn't impose its own env vars on to applications. It should be the application author that decides how to handle env vars.",
"created_at": "2022-03-27T17:14:26Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "@joouha I think I need to understand your use case a bit more. Would you be free for a video chat, next week perhaps?",
"created_at": "2022-04-02T08:42:07Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Closing. Assumed stale. ",
"created_at": "2022-09-19T09:46:10Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 2084,
"pr_title": "fix: full static typing, fix issues discovered",
"pr_url": "https://github.com/Textualize/rich/pull/2084",
"pr_author": "henryiii",
"created_at": "2022-03-18T17:40:33Z",
"closed_at": "2022-03-21T17:16:31Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "There is little point in typechecking examples. They are for educational purposes, and I don't want to assume the viewer is familiar with type annotations. That includes `mypy:` comments which have the potential to confuse.\r\n\r\nIf anything, the types should be removed from the examples, unless it is particularly relevant.",
"created_at": "2022-03-19T17:10:49Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Hi Henry\r\n\r\nCould you break this PR in to manageable chunks. Hard to see the wood for the trees.\r\n\r\nexamples and tools don't need typing.\r\n\r\nThanks",
"created_at": "2022-03-19T17:25:03Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 2013,
"pr_title": "Add the `log_omit_repeated_times` option to `Console`",
"pr_url": "https://github.com/Textualize/rich/pull/2013",
"pr_author": "apcamargo",
"created_at": "2022-02-28T17:49:12Z",
"closed_at": "2023-03-04T11:03:42Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "The constructor already has a large argument list. I'd prefer not to add to it without good reason.\r\n\r\nWhat is your use case? Why do you not want identical times removed from the log function?",
"created_at": "2022-03-27T21:37:28Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "This option makes sense for logging, but less so for `Console.log`. Not worth adding yet another option. Thanks for the contribution.",
"created_at": "2023-03-04T11:03:41Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 1985,
"pr_title": "Hy support during inspection",
"pr_url": "https://github.com/Textualize/rich/pull/1985",
"pr_author": "shadowrylander",
"created_at": "2022-02-20T23:24:00Z",
"closed_at": "2022-02-22T16:50:36Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "I'm afraid I couldn't advocate for adding code to inspect for specific object types. Especially something I am not familiar with. I'd suggest extracting this version of inspect in to your own code somewhere.",
"created_at": "2022-02-22T16:50:36Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "If you wish. But equally you could just extract inspect.py",
"created_at": "2022-02-22T18:53:47Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "I don\u2019t recall. But you could easily change those.",
"created_at": "2022-02-22T19:02:55Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 1981,
"pr_title": "Pass Console parameters passed to logging.RichHandler constructor",
"pr_url": "https://github.com/Textualize/rich/pull/1981",
"pr_author": "ProfDiesel",
"created_at": "2022-02-18T22:48:57Z",
"closed_at": "2022-02-26T19:14:17Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Sorry, not keen on this change. A union of a Console and a dict of Any is an invitation for typing errors.\r\n\r\nI'd suggest exposing an entrypoint for the handler in your own project.",
"created_at": "2022-02-26T19:14:17Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 1958,
"pr_title": "removed unused import from __init__.py",
"pr_url": "https://github.com/Textualize/rich/pull/1958",
"pr_author": "vivekvashist",
"created_at": "2022-02-13T10:59:47Z",
"closed_at": "2022-02-13T15:33:18Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Used by the iPython extension.",
"created_at": "2022-02-13T15:33:18Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 1955,
"pr_title": "refactor: increase code quality",
"pr_url": "https://github.com/Textualize/rich/pull/1955",
"pr_author": "wizard-28",
"created_at": "2022-02-12T11:10:18Z",
"closed_at": "2022-02-12T11:21:22Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Countless pointless changes, and you broke the tests. Please do not submit anything from Soucery again or I will block you.",
"created_at": "2022-02-12T11:21:22Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 1943,
"pr_title": "Fix red extension",
"pr_url": "https://github.com/Textualize/rich/pull/1943",
"pr_author": "sheerluck",
"created_at": "2022-02-09T14:36:13Z",
"closed_at": "2022-02-10T11:50:44Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "It's just an example. ",
"created_at": "2022-02-10T11:50:44Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 1918,
"pr_title": "Fixed force_terminal on Jupyter",
"pr_url": "https://github.com/Textualize/rich/pull/1918",
"pr_author": "verdimrc",
"created_at": "2022-02-04T20:03:59Z",
"closed_at": "2022-07-06T08:36:56Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Why would you `force_terminal` in Jupyter lab?\r\n\r\nPlease don't ask me to run something in Jupyter when you can paste a screenshot.",
"created_at": "2022-02-13T15:37:11Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "> Why would you force_terminal in Jupyter lab?\r\n",
"created_at": "2022-02-27T10:52:34Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "I'm going to need an answer to my question, and some code I can cut and paste (or a notebook).",
"created_at": "2022-05-03T10:32:02Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 1902,
"pr_title": "Fix #1530",
"pr_url": "https://github.com/Textualize/rich/pull/1902",
"pr_author": "GBeauregard",
"created_at": "2022-02-01T10:30:59Z",
"closed_at": "2022-02-01T10:32:47Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "@GBeauregard This may fix the error, but it breaks the intended behaviour.\r\n\r\nThe context manager in Console does *not* lock any threads. It is intended to prevent interleaving in output when writing from multiple threads. It does this by writing to a thread-local buffer and only write to the console on exit.\r\n\r\nIt is more efficient this way because there is no waiting for exclusive access from threads.\r\n\r\nAdding the thread lock will break this behaviour.",
"created_at": "2022-02-01T10:38:27Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 1852,
"pr_title": "Default datetime Highlighting",
"pr_url": "https://github.com/Textualize/rich/pull/1852",
"pr_author": "aaronst",
"created_at": "2022-01-19T23:36:44Z",
"closed_at": "2022-01-20T11:57:53Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "I'm not keen on adding much more to that list of regexes, as it is quite large already and each new one slows highlighting down a little.\r\n\r\nYou could always create a custom highlighter if you need this.",
"created_at": "2022-01-20T11:57:53Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 1826,
"pr_title": "Replacing some uses of cell_len with Cells.measure",
"pr_url": "https://github.com/Textualize/rich/pull/1826",
"pr_author": "darrenburns",
"created_at": "2022-01-11T10:42:45Z",
"closed_at": "2022-01-13T14:27:50Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Yeah, definitely on the right track.\r\n\r\nI'll push cells to Pypi and tag it with alpha.",
"created_at": "2022-01-11T10:47:17Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 1823,
"pr_title": "Bump mypy from 0.930 to 0.931",
"pr_url": "https://github.com/Textualize/rich/pull/1823",
"pr_author": "dependabot[bot]",
"created_at": "2022-01-10T13:33:20Z",
"closed_at": "2022-02-27T10:54:24Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "@dependabot recreate",
"created_at": "2022-02-27T10:33:03Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "@dependabot rebase",
"created_at": "2022-02-27T10:49:02Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 1792,
"pr_title": "Update year to 2022",
"pr_url": "https://github.com/Textualize/rich/pull/1792",
"pr_author": "Awilum",
"created_at": "2022-01-02T09:02:44Z",
"closed_at": "2022-01-06T11:21:28Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Thanks, but this isn't required. https://hynek.me/til/copyright-years/",
"created_at": "2022-01-06T11:21:28Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 1779,
"pr_title": "Add support for indices in Prompt",
"pr_url": "https://github.com/Textualize/rich/pull/1779",
"pr_author": "TheTrio",
"created_at": "2021-12-24T22:26:44Z",
"closed_at": "2021-12-31T10:27:59Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Sorry, I don't think this offers much over the current functionality. You can display a list of things in the prompt. If you really need it, a subclass is probably the way to go. ",
"created_at": "2021-12-31T10:27:59Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 1740,
"pr_title": "Bump black from 21.11b1 to 21.12b0",
"pr_url": "https://github.com/Textualize/rich/pull/1740",
"pr_author": "dependabot[bot]",
"created_at": "2021-12-06T13:05:05Z",
"closed_at": "2021-12-16T16:38:54Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "@dependabot rebase",
"created_at": "2021-12-12T10:46:33Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 1705,
"pr_title": "Add support for showing threads with RichHandler",
"pr_url": "https://github.com/Textualize/rich/pull/1705",
"pr_author": "hemna",
"created_at": "2021-11-17T16:03:22Z",
"closed_at": "2021-11-28T16:26:36Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "How can you be sure that it won't generate unreadable colors on a given background?",
"created_at": "2021-11-17T16:05:36Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "I'm afraid I don't think this is a good. I can see why you might want it, but it's not generally useful enough to go in the core lib. For the moment, I would suggest just copying your custom RichHandler to your own project.\r\n\r\nIn the future, maybe RichHandler will grow some way of customizing columns in a more data-driven way.",
"created_at": "2021-11-28T16:26:36Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "I meant to say \"good idea\"",
"created_at": "2021-11-28T16:45:34Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "It's not a good idea to add one specific use case to the core library. I can't satisfy every use case, so I need to draw a line somewhere, to keep the interface manageable.\r\n\r\nI'm not preventing you from achieving what you need, since you clearly know how to extend the RichHandler.",
"created_at": "2021-12-02T18:36:02Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 1694,
"pr_title": "Bump typing-extensions from 3.10.0.2 to 4.0.0",
"pr_url": "https://github.com/Textualize/rich/pull/1694",
"pr_author": "dependabot[bot]",
"created_at": "2021-11-15T13:04:48Z",
"closed_at": "2021-11-16T14:28:48Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "@dependabot rebase",
"created_at": "2021-11-15T15:46:58Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 1675,
"pr_title": "Add a Text.from_ansi helper method",
"pr_url": "https://github.com/Textualize/rich/pull/1675",
"pr_author": "0xDEC0DE",
"created_at": "2021-11-10T17:27:00Z",
"closed_at": "2021-11-17T21:22:56Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "I think this is a good idea. And a nice way of exposing that ANSIDecoder class. Just one request.",
"created_at": "2021-11-16T15:09:28Z",
"type": "review",
"review_state": "CHANGES_REQUESTED"
}
]
},
{
"pr_number": 1639,
"pr_title": "Add rich-markdown CLI script",
"pr_url": "https://github.com/Textualize/rich/pull/1639",
"pr_author": "fredrikaverpil",
"created_at": "2021-11-03T07:11:24Z",
"closed_at": "2021-11-05T17:07:10Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "I'm not keen on this. Appreciate you find it useful, I just don't think it should be the job of a library to install such tools. I'd prefer if this was installed via a another package on Pypi. ",
"created_at": "2021-11-05T17:07:10Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 1621,
"pr_title": "allow for callable in rich.traceback.install(suppress=\u2026)",
"pr_url": "https://github.com/Textualize/rich/pull/1621",
"pr_author": "jettero",
"created_at": "2021-10-24T16:22:42Z",
"closed_at": "2023-03-04T11:01:55Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Docs and tests please.",
"created_at": "2021-11-06T13:11:06Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Closing. Assumed stale.",
"created_at": "2023-03-04T11:01:55Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 1609,
"pr_title": "Indeterminate progress tracking",
"pr_url": "https://github.com/Textualize/rich/pull/1609",
"pr_author": "mrvkino",
"created_at": "2021-10-19T03:19:28Z",
"closed_at": "2022-05-03T10:35:50Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "I'm afraid I can't accept the `float(\"inf\")`. A significant number of people will find this surprising.\r\n\r\n",
"created_at": "2021-12-14T14:11:46Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "We now support total=None for indeterminate progress bars.",
"created_at": "2022-05-03T10:35:50Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 1605,
"pr_title": "feat: receive custom depth on rich.pretty \u2728",
"pr_url": "https://github.com/Textualize/rich/pull/1605",
"pr_author": "meysam81",
"created_at": "2021-10-17T11:24:18Z",
"closed_at": "2021-10-17T15:53:23Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "I'm afraid I'm not doing Hacktober this year.\r\n\r\nThis PR doesn't set the depth of the pretty print. It's not the indent size that is needed.\r\n\r\nThe depth refers to the depth of nesting.\r\n\r\nThis list has a depth of 1:\r\n\r\n```python\r\n[\r\n \"a\"\r\n]\r\n```\r\n\r\nThis list has a depth of 2:\r\n\r\n```python\r\n[\r\n [\r\n \"b\"\r\n ]\r\n]\r\n```",
"created_at": "2021-10-17T15:51:16Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 1604,
"pr_title": "Many Miscellaneous Typing Fixes",
"pr_url": "https://github.com/Textualize/rich/pull/1604",
"pr_author": "GBeauregard",
"created_at": "2021-10-17T02:40:14Z",
"closed_at": "2022-02-01T10:05:09Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "I'm not willing to give up on the setter accepting a variety of types, but I don't want to move the burden to the caller.\r\n\r\nPersonally I think the typechecker should allow this. It could look at the setter to determine what types may be set.\r\n\r\nI'm going to talk to the Mypy devs to get their opinion on this. With a bit of luck, a future version of Mypy may allow it.",
"created_at": "2021-10-18T08:57:18Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "So there is an issue on this.\r\n\r\nhttps://github.com/python/mypy/issues/3004\r\n\r\nThere seems to be some motivation to fix it, but it's an old issue. So not likely to happen any time soon.\r\n\r\nRegardless, I think it should stay. The caller can fix it their side by adding `ConsoleDImensions`. If Pyright complains about the setter itself we can ignore that in the library.\r\n\r\nTBH My motivation to fix all Pyright errors is low, unless they indicate legitimate bugs. Getting two linters to agree doesn't always make better code.",
"created_at": "2021-10-18T09:35:56Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Turns it you can have a different type in the setter with a descriptor. Would you like to tackle that? Otherwise, I'll add it on the next iteration.",
"created_at": "2021-10-18T10:46:54Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 1602,
"pr_title": "feat(bars): pause and resume methods to progress bars",
"pr_url": "https://github.com/Textualize/rich/pull/1602",
"pr_author": "v0lp3",
"created_at": "2021-10-16T21:50:37Z",
"closed_at": "2021-11-05T17:13:16Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "This isn't what I meant in the issue.\r\n\r\nThe pause and resume I had in mind would pause the rendering of the progress bar(s), allowing input() to use stdin. Trickier than it seems because it would have to interact with a threads. Feel free to tackle that if you like.\r\n\r\n",
"created_at": "2021-11-05T17:13:16Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 1601,
"pr_title": "Iluminnatti Branch - updating archives",
"pr_url": "https://github.com/Textualize/rich/pull/1601",
"pr_author": "iluminnatti",
"created_at": "2021-10-16T19:19:50Z",
"closed_at": "2021-11-06T13:16:05Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "I see little benefit in moving the READMEs in to a directory.",
"created_at": "2021-10-16T19:22:36Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 1600,
"pr_title": "fix: Dataclass pretty repr can contain a trailing separator and whitespace",
"pr_url": "https://github.com/Textualize/rich/pull/1600",
"pr_author": "ochilly",
"created_at": "2021-10-16T05:40:25Z",
"closed_at": "2021-11-07T16:17:18Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Fixed in 10.13.0. THanks.",
"created_at": "2021-11-07T16:17:18Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 1572,
"pr_title": "Bump types-dataclasses from 0.1.7 to 0.6.0",
"pr_url": "https://github.com/Textualize/rich/pull/1572",
"pr_author": "dependabot[bot]",
"created_at": "2021-10-12T13:03:15Z",
"closed_at": "2021-10-16T09:46:56Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "@dependabot rebase\r\n",
"created_at": "2021-10-16T09:35:31Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 1551,
"pr_title": "Fix all reportPrivateImportUsage in pyright for library users",
"pr_url": "https://github.com/Textualize/rich/pull/1551",
"pr_author": "GBeauregard",
"created_at": "2021-10-07T08:27:17Z",
"closed_at": "2021-10-16T09:38:49Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "I'm not overly keen on that workaround. The main sections are excluded from coverage, but I still like them to be typechecked.\r\n\r\nCould the individual lines be excluded in Pyright, rather than the entire block?",
"created_at": "2021-10-15T09:14:42Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Thanks. I think I'll go with 2. \r\n\r\n3. Isn't really an option. The main blocks are fairly integral and popular feature.",
"created_at": "2021-10-16T09:38:49Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 1544,
"pr_title": "Correct typing of Iterables and small narrowing",
"pr_url": "https://github.com/Textualize/rich/pull/1544",
"pr_author": "GBeauregard",
"created_at": "2021-10-04T08:07:04Z",
"closed_at": "2021-10-04T15:46:26Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "I don't want to promise that the return type has a `__next__` method, all I want to promise is that I'm returning something that may be iterated over. This allows me to change the return type to some other iterable in the future, safe in the knowledge that code using it won't break.\r\n\r\nThere may be some room for changing `Any` to `object`. It could conceivably catch bugs in the future.",
"created_at": "2021-10-04T09:52:39Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 1512,
"pr_title": "Allow limiting of consecutive log time omissions.",
"pr_url": "https://github.com/Textualize/rich/pull/1512",
"pr_author": "aidaco",
"created_at": "2021-09-23T06:23:13Z",
"closed_at": "2022-09-19T09:45:29Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Can you elaborate on what this does?",
"created_at": "2021-09-30T11:18:11Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Closing. Assumed stale. Feel free to reopen if you want to continue work on it.",
"created_at": "2022-09-19T09:45:29Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 1497,
"pr_title": "WIP: transient progress.track #1488",
"pr_url": "https://github.com/Textualize/rich/pull/1497",
"pr_author": "RonnyPfannschmidt",
"created_at": "2021-09-18T11:18:35Z",
"closed_at": "2022-09-19T09:43:49Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "`transient` is probably the wrong term, since it is used elsewhere with a somewhat different meaning. I'd suggest 'hide_finished`",
"created_at": "2021-09-30T11:25:28Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Any chance you can have another look at this?",
"created_at": "2021-10-15T09:06:39Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Closing, assumed stale",
"created_at": "2022-09-19T09:43:49Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 1495,
"pr_title": "Add additional check in __get__ for _Bit class",
"pr_url": "https://github.com/Textualize/rich/pull/1495",
"pr_author": "kylepollina",
"created_at": "2021-09-18T04:32:57Z",
"closed_at": "2021-09-18T17:43:04Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "I don't know of a situation where you would need to access that property without an instance. Do you have a use-case for this?",
"created_at": "2021-09-18T07:52:52Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Ah. I'm afraid you can't assume that. You will encounter many more examples of attributes where accessing them throws an exception.\r\n\r\nYour object explorer looks very cool, BTW.",
"created_at": "2021-09-18T09:52:24Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 1473,
"pr_title": "Add arrows option to rich.tree",
"pr_url": "https://github.com/Textualize/rich/pull/1473",
"pr_author": "tusharsadhwani",
"created_at": "2021-09-09T12:54:36Z",
"closed_at": "2022-06-14T09:15:43Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "I've never seen trees with arrows before. Where did you see them?",
"created_at": "2021-09-09T12:56:13Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Could you add some way to specify the arrows per-node? In-fact, maybe there are other ways of terminating the guides?\r\n\r\n",
"created_at": "2021-09-12T15:14:54Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "That's what I was thinking. There may be [other symbols](https://www.compart.com/en/unicode/block/U+2B00) that make sense.",
"created_at": "2021-09-12T15:46:03Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "You may be right! But even so, it would be nice to specify them per node.",
"created_at": "2021-09-12T15:50:07Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Be my guest.",
"created_at": "2021-09-12T15:53:18Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Hi Tushar. Do you want to persevere with this one? Unless it is per-node I don't think it will be generally useful.",
"created_at": "2022-02-27T10:32:15Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Going to close this for now. Just house-keeping. If you do find the time, feel free to re-open when its ready for a review!",
"created_at": "2022-06-14T09:15:43Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 1468,
"pr_title": "Fix typo in date",
"pr_url": "https://github.com/Textualize/rich/pull/1468",
"pr_author": "tusharsadhwani",
"created_at": "2021-09-04T15:16:11Z",
"closed_at": "2021-09-07T07:34:22Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Good spot, but now the screenshots would not match the code. Honestly I don't think its worth the effort to fix those!",
"created_at": "2021-09-07T07:34:22Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 1446,
"pr_title": "Added support to print specific key in a json ",
"pr_url": "https://github.com/Textualize/rich/pull/1446",
"pr_author": "sureshdsk",
"created_at": "2021-08-29T17:29:34Z",
"closed_at": "2021-09-01T07:00:54Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Why do you need this? I don't see this as being particularly useful in its current form. Perhaps if it was more sophisticated than a single key, but then it would be something outside of the scope of Rich. ",
"created_at": "2021-08-30T10:12:11Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 1382,
"pr_title": "Optimisation suggestions for Segment.divide()",
"pr_url": "https://github.com/Textualize/rich/pull/1382",
"pr_author": "AlexWaygood",
"created_at": "2021-08-03T16:48:36Z",
"closed_at": "2021-08-03T20:57:39Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "The annotations are only evaluated at import time, so shouldn't have any impact.\r\n\r\nGood suggestions, but these micro-optimizations probably won't make a measurable impact. I'm looking for a more algorithmic improvement.",
"created_at": "2021-08-03T20:57:39Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 1304,
"pr_title": "cyberpunk bars",
"pr_url": "https://github.com/Textualize/rich/pull/1304",
"pr_author": "msaroufim",
"created_at": "2021-06-20T01:52:18Z",
"closed_at": "2021-06-21T11:56:39Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Thanks but I like the red. Looks like a sunset.",
"created_at": "2021-06-21T11:56:39Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 1290,
"pr_title": "GitHub Action to lint Python code",
"pr_url": "https://github.com/Textualize/rich/pull/1290",
"pr_author": "cclauss",
"created_at": "2021-06-12T12:02:18Z",
"closed_at": "2021-06-14T07:13:05Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "I already run black, mypy, and pytest.\r\n\r\nI suspect many of these linters will create pointless busy work. e.g. I use iSort in the editor, but frankly if an import is out of order, it doesn't matter if it gets checked in,",
"created_at": "2021-06-14T06:49:26Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 1288,
"pr_title": "Exploratory Contribution: MUD Support (MXP/Pueblo)",
"pr_url": "https://github.com/Textualize/rich/pull/1288",
"pr_author": "volundmush",
"created_at": "2021-06-11T21:33:11Z",
"closed_at": "2021-06-15T08:50:55Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "You've done some very interesting work there, but MUD support is probably too niche to add to the core library. You are probably better off with a fork of the lib. You could even publish it on Pypy as rich-mud or something. ",
"created_at": "2021-06-12T09:27:32Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 1221,
"pr_title": "Make Spyder be recognized as a Jupyter environment",
"pr_url": "https://github.com/Textualize/rich/pull/1221",
"pr_author": "ccordoba12",
"created_at": "2021-05-08T18:36:41Z",
"closed_at": "2021-06-09T17:51:21Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "I think there are two issue which break Rich in Spyder. The first is that Spyder wraps stdout with a file object where `isatty` returns False. Rich uses that method to disable color when not writing to a terminal. I see that issue was raised on the Spyder repo.\r\n\r\nThe second may be colorama which is a bit of a hack on Windows to get color on the classic terminal. It works fine for a terminal running with conhost.exe but not an emulated terminal as I guess you have in Spyder. Unfortunately, I don't have a good solution for this issue. You could run `colorama.deinit` but that wouldn't work out-of-the box.\r\n\r\nAn env var may be best workaround at the moment, but I wouldn't approve of a specific env var for every IDE or terminal window. Possibly we could come up with a generic env var.\r\n\r\nHappy to brainstorm ideas, because of course I would want Spyder users to be able to enjoy Rich.\r\n\r\nThat said, if this change works for you, I could merge that. But bear in mind that Jupyter support may not be as good as a regular terminal. There's no way in Jupyter to get the width of the terminal which is needed for things like Panels and Tables.",
"created_at": "2021-05-09T07:58:14Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "@ccordoba12 colorama shouldn't have any effect on other platforms. From the docs:\r\n\r\n> On other platforms, calling init() has no effect (unless you request other optional functionality; see \u201cInit Keyword Args\u201d, below). By design, this permits applications to call init() unconditionally on all platforms, after which ANSI output should just work.\r\n\r\nBy the looks of things, I can set `strip=False` globally. If you make sure that `isatty()` returns True for your wrapped stdout, then I think that will give you Rich support. If that works for you, I can add it to the next version.\r\n\r\nA related is that Rich is unable to detect the terminal size, so it will be stuck at 80 columns. This is because `os.get_terminal_size` is throwing an error on Spyder.",
"created_at": "2021-05-10T16:29:44Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "THis should be fixed in Spider could return True from its proxy isatty()",
"created_at": "2021-06-09T17:51:21Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 1218,
"pr_title": "fix color output in spyder console",
"pr_url": "https://github.com/Textualize/rich/pull/1218",
"pr_author": "eendebakpt",
"created_at": "2021-05-07T12:44:59Z",
"closed_at": "2021-05-08T11:33:14Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "I can't accept a fudge for a specific IDE. Colorama is a headache for Rich as it makes global changes, whereas Rich can have different settings per-Console instance.\r\n\r\nI'd suggest setting `force_terminal` on the constructor if Spyder is reporting it is not a real terminal. You can also reinit colorama after importing rich to fix that issue.",
"created_at": "2021-05-08T11:33:14Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 1167,
"pr_title": "Fixes a split_row() bug in examples/fullscreen.py",
"pr_url": "https://github.com/Textualize/rich/pull/1167",
"pr_author": "chief8192",
"created_at": "2021-04-13T11:47:20Z",
"closed_at": "2021-04-13T12:05:36Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "I think you may have an older version of Rich installed, because the direction argument was removed in version 10.0.0",
"created_at": "2021-04-13T12:05:36Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 1152,
"pr_title": "introduction.rst: Correct some Windows details",
"pr_url": "https://github.com/Textualize/rich/pull/1152",
"pr_author": "SamB",
"created_at": "2021-04-02T02:21:43Z",
"closed_at": "2021-04-02T12:31:36Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "The title of the window is cmd.exe which is more recognisable. Not sure many people would know what is meant by \"classic console\".\r\n\r\nThe situation is messy on Windows where its difficult to auto-detect features for the \"classic terminal\". Rich relies on colorama to handle pre-virtual terminal sequences, while Windows Terminal gets all the features.",
"created_at": "2021-04-02T12:31:36Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 1145,
"pr_title": "Add checkMark and crossMark status",
"pr_url": "https://github.com/Textualize/rich/pull/1145",
"pr_author": "davidbrochart",
"created_at": "2021-03-30T14:04:26Z",
"closed_at": "2021-03-30T18:47:29Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Not sure why you would need that. Presumably once you are done, you can exit the status context and print whatever you like?",
"created_at": "2021-03-30T17:11:45Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Fair enough. Seems like a reasonable solution.",
"created_at": "2021-03-30T17:32:10Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Actually, it may be a little too specific. I can imagine other users wanting different unicode symbols and I couldn't add a spinner for all requirements.\r\n\r\nCould you replace the spinner with `Text(\"\u2705 Done\")` (or cross) as needed?",
"created_at": "2021-03-30T17:36:22Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "I meant replace status instance with a new Text instance.\r\n\r\nIf you have a Tree node (returned from Tree.add) you can do this:\r\n\r\n```python\r\ntree_node.label = \"\u2705 Done\"\r\n```\r\n\r\nWhich will replace the status with Text.\r\n\r\nAlternatively you could implement a renderable that returns a Spinner or the desired text. Something along these lines:\r\n\r\n```python\r\nclass MyLabel:\r\n def __init__(self):\r\n self.spinner = Spinner()\r\n \r\n def __rich__(self):\r\n if is_finished():\r\n return \"Done\" if status == \"done\" else \"Fail\"\r\n else:\r\n return self.spinner\r\n\r\ntree = Tree()\r\ntree.add(MyLabel())\r\n```\r\n\r\n",
"created_at": "2021-03-30T18:36:00Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 1118,
"pr_title": "Allow Console.print(markup=) to override Console defaults",
"pr_url": "https://github.com/Textualize/rich/pull/1118",
"pr_author": "0xDEC0DE",
"created_at": "2021-03-17T20:40:04Z",
"closed_at": "2021-03-25T14:32:13Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Close, but no cigar.\r\n\r\nThis will disable markup for every subsequent print. The fix is probably to add `markup` to ConsoleOptions.\r\n\r\nIn the meantime, you can wrap your table cells in a `rich.text.Text` instance.",
"created_at": "2021-03-17T21:27:32Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "There will be a fix for this in the next version.",
"created_at": "2021-03-25T14:32:13Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 1113,
"pr_title": "Function Name in Logger by Default",
"pr_url": "https://github.com/Textualize/rich/pull/1113",
"pr_author": "sizhky",
"created_at": "2021-03-17T15:18:47Z",
"closed_at": "2021-03-17T15:58:12Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "I wouldn't want to do this by default, mainly for space issues--a long function name could leave little space for the rest of the log text.\r\n\r\nIt would be a nice addition, but it would have to be optional and off by default.\r\n\r\n",
"created_at": "2021-03-17T15:31:18Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 1107,
"pr_title": "Support extras in logging handler",
"pr_url": "https://github.com/Textualize/rich/pull/1107",
"pr_author": "traviscook21",
"created_at": "2021-03-11T18:10:12Z",
"closed_at": "2021-03-16T17:34:00Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "This is not something that the extra dict is typically used for, AFAIK. But I can see why you would want to pass in something to pretty print.\r\n\r\nI'm not keen on the filtering out reserved words. What I would accept is a single key that accepts a Rich renderable. There's less change of a key overlapping with something in the futures. Perhaps something like this:\r\n\r\n```python\r\nlog.debug(\"Result\", extra={\"rich.print\": results_table})\r\n```",
"created_at": "2021-03-11T21:36:56Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Setting the entire `extra` to your JSON is a bad idea precisely because of this mushing of namespaces together. There's no way to know wether your keys were part of the JSON or intended as part of the log message. \r\n\r\nLogging is way to dynamic to simply keep a include / exclude list. You may not have any control about what other handlers are in use when your code is in production.\r\n\r\nThe only way to be confident your JSON keys don't trample on something else would be to pick one key and put your data in that. It's slightly more verbose, but hardly that bad.\r\n\r\n```python\r\nlog.debug(\"Result\", extras={\"print\", my_json})\r\n```\r\n\r\nActually, \"rich\" may be a better key, as it's less likely to conflict.\r\n\r\n```python\r\nlog.debug(\"Result\", extras={\"rich\", my_json})\r\n```",
"created_at": "2021-03-12T11:55:12Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 1085,
"pr_title": "Fix google colab",
"pr_url": "https://github.com/Textualize/rich/pull/1085",
"pr_author": "davidt0x",
"created_at": "2021-03-02T22:16:10Z",
"closed_at": "2021-03-06T15:25:46Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Seems reasonable. I'll include this in the next release.\r\n\r\nI wish there was a better way for Jupyter-like implementations to advertise their capabilties.",
"created_at": "2021-03-04T13:03:50Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Thanks. Closing this, but the fix is in another branch. New release today.",
"created_at": "2021-03-06T15:25:46Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 1068,
"pr_title": "chore : Fixed code quality issues",
"pr_url": "https://github.com/Textualize/rich/pull/1068",
"pr_author": "powerexploit",
"created_at": "2021-02-26T12:01:43Z",
"closed_at": "2021-02-26T14:12:37Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "I generally won't accept any deepsource PRs as I've never seen it actually fix anything, and I don't want to give the impression that I recommend it.",
"created_at": "2021-02-26T14:12:37Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 1065,
"pr_title": "Test prompt confirm with choices",
"pr_url": "https://github.com/Textualize/rich/pull/1065",
"pr_author": "neutrinoceros",
"created_at": "2021-02-26T09:02:44Z",
"closed_at": "2021-03-15T14:53:36Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "The Prompt classes were intended to be extended for things like this. For instance your YES/NO prompt could be implemented as follows:\r\n\r\n```python\r\nclass VerboseConfirm(Confirm):\r\n choices = [\"yes\", \"no\"]\r\n validate_error_message = \"[prompt.invalid]Please enter YES or NO\"\r\n\r\nVerboseConfirm.ask(\"continue?\")\r\n```\r\n\r\nYou have a reasonable point about including the choices in the error message, but for a confirmation prompt it would be rare to have to write it more than once.",
"created_at": "2021-02-26T14:09:20Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Thanks @neutrinoceros Closing this for now. I think I just need to expand on this use-case in the docs.",
"created_at": "2021-03-15T14:53:36Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 1003,
"pr_title": "fix printing sequences with overflow=wrap",
"pr_url": "https://github.com/Textualize/rich/pull/1003",
"pr_author": "nathanrpage97",
"created_at": "2021-02-12T08:30:48Z",
"closed_at": "2021-02-17T09:51:39Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Thanks @nathanrpage97 Closing this because I made similar changes in a branch.",
"created_at": "2021-02-17T09:51:39Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 992,
"pr_title": "dune fix 2",
"pr_url": "https://github.com/Textualize/rich/pull/992",
"pr_author": "ruppde",
"created_at": "2021-02-07T11:43:10Z",
"closed_at": "2021-02-20T16:39:53Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Fixed in master. Thanks.",
"created_at": "2021-02-20T16:39:53Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 991,
"pr_title": "fix dune typos :)",
"pr_url": "https://github.com/Textualize/rich/pull/991",
"pr_author": "ruppde",
"created_at": "2021-02-06T11:29:44Z",
"closed_at": "2021-02-07T11:47:39Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Some of those typos were also involved in tests. Any chance of a fix?",
"created_at": "2021-02-07T10:32:50Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Don\u2019t know if you can expand the details. It\u2019s failing on the black format test. If you run the latest black on rich and tests it should be good to go.\r\n\r\nI just hope they don\u2019t postpone the movie again!",
"created_at": "2021-02-07T11:04:30Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 954,
"pr_title": "Fix initial table headers missing style",
"pr_url": "https://github.com/Textualize/rich/pull/954",
"pr_author": "luizyao",
"created_at": "2021-01-23T02:00:54Z",
"closed_at": "2021-01-23T15:53:20Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Thanks, but I had already fixed this. Please try v9.9.0",
"created_at": "2021-01-23T15:53:20Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 943,
"pr_title": "fix: traceback+chdir / slow traceback if FileNotFound / leading lines in source code",
"pr_url": "https://github.com/Textualize/rich/pull/943",
"pr_author": "TyberiusPrime",
"created_at": "2021-01-19T15:54:58Z",
"closed_at": "2021-01-23T15:53:55Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Hi @TyberiusPrime \r\n\r\nThanks for reporting these issues. It think I might work on these in another branch, as I think there be some alternate solutions.\r\n\r\nI think the slowness you've observed in the example with Pandas may be due to the size of the files. Rich will syntax highlight the entire file before cutting out a few lines. I'm sure there are ways that could be done more efficiently.\r\n\r\nThe issue with cwd is a new one one me, I'll check that. Ditto the issue with files starting with a new line.",
"created_at": "2021-01-21T17:16:18Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Please try v9.9.0 which addresses these issue.",
"created_at": "2021-01-23T15:53:55Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 928,
"pr_title": "Do not join refresh thread for Live under lock",
"pr_url": "https://github.com/Textualize/rich/pull/928",
"pr_author": "cjolowicz",
"created_at": "2021-01-14T23:29:18Z",
"closed_at": "2021-01-15T10:23:53Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Closing if favor of https://github.com/willmcgugan/rich/pull/930",
"created_at": "2021-01-15T10:10:22Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 868,
"pr_title": "add progress component that works cleanly with Live",
"pr_url": "https://github.com/Textualize/rich/pull/868",
"pr_author": "nathanrpage97",
"created_at": "2020-12-30T22:10:12Z",
"closed_at": "2021-02-03T23:01:19Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Hi @nathanrpage97 \r\n\r\nI see the need for this, bit I'm not keen on this `RenderProgress` class with stubs for `start()` etc.\r\n\r\nCould we factor out a `ProgressRenderable` that handles the state and rendering, and extend that with the refresh thread etc to create the Progress class.\r\n\r\nIn psuedo-code...\r\n\r\n```python\r\nclass ProgressRenderable:\r\n def add_task(self, ...):\r\n ...\r\n def __rich_console__(self,...):\r\n ...\r\n\r\nclass Progress(ProgressRenderable):\r\n def start(self):\r\n ...\r\n```\r\n\r\nEssentially adding functionality to the renderable to create a Progress class, rather than subtracting from Progress to create a renderable -- if that makes sense!",
"created_at": "2021-01-20T15:44:16Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "> I was going to do it that way, the issue I had is that it would imply to a users IDE that the Progress component is RichRenderable when it is not.\r\n\r\nI think it would be Rich renderable. It wouldn't be the recommended way to use Progress, but I don't see any harm in being able to do `console.print(progress)`. ",
"created_at": "2021-01-20T17:54:06Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "@nathanrpage97 You might want to hold off. I'd like to refactor Progress so that it uses the functionality in Live. I'm also thinking about ways to supported nested Live / Progress.",
"created_at": "2021-02-03T19:27:02Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 500,
"pr_title": "Add example notebooks",
"pr_url": "https://github.com/Textualize/rich/pull/500",
"pr_author": "donno2048",
"created_at": "2020-12-15T13:45:41Z",
"closed_at": "2021-02-01T14:11:54Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "> Also, I'm not sure for some of the simpler ones if using console.print() and not simply the print() imported from rich is warranted? I'm not seeing the dynamic adjusting in the notebook context with console.print() in regards to the width as discussed at the end of this section in the documentation. So maybe it is misleading?\r\n\r\n`console.print` has additional features over `rich.print` as it doesn't need to conform to the builtin print.\r\n\r\nRich can't detect the width of the 'terminal' when running in Jupyter, so it's fixed.\r\n\r\nI've been delaying merging this as it feels unnecessary when you can do it in the terminal. But I guess for some Jupyter is the primary interface to Python.",
"created_at": "2021-01-12T18:41:04Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 469,
"pr_title": "Fix code quality issues",
"pr_url": "https://github.com/Textualize/rich/pull/469",
"pr_author": "withshubh",
"created_at": "2020-12-06T12:27:59Z",
"closed_at": "2020-12-06T15:27:27Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "I find these tools have so many false positives they just create busy-work that has no real impact. I'm afraid this PR just confirm that.",
"created_at": "2020-12-06T15:27:27Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 423,
"pr_title": "Strip ANSI escapes when producing HTML",
"pr_url": "https://github.com/Textualize/rich/pull/423",
"pr_author": "ssbarnea",
"created_at": "2020-11-01T09:54:34Z",
"closed_at": "2020-11-08T12:35:42Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "This won't be necessary in 9.2.0. If you have a look at the FileProxy class in Progress, it now decodes ANSI styles.",
"created_at": "2020-11-08T12:35:42Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 421,
"pr_title": "Make TimeRemainingColumn in progress.track optional ",
"pr_url": "https://github.com/Textualize/rich/pull/421",
"pr_author": "senpos",
"created_at": "2020-10-31T17:14:18Z",
"closed_at": "2020-12-12T12:47:07Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "I'm not keen on this, tbh.\r\n\r\nI can see why it's useful, but I suspect somebody will ask for a `show_description` and `show_bar` etc. And there are already a fair number of configuration options on that method.\r\n\r\nI think its best I draw a line under the parameters on that function given that you can build a Progress instance with your requirements for columns (like you said).\r\n\r\nI'll leave this open for now, but I'll listen if you have any counter-points!",
"created_at": "2020-12-11T14:44:36Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 420,
"pr_title": "WIP: New spinner code",
"pr_url": "https://github.com/Textualize/rich/pull/420",
"pr_author": "josephgeis",
"created_at": "2020-10-31T16:52:00Z",
"closed_at": "2020-11-19T10:26:41Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "This is a fine solution for a stand-alone spinner. But it doesn't really make use of Rich. There's no way to use Rich's [console markup](https://rich.readthedocs.io/en/latest/markup.html) for example.\r\n\r\nI think it should be implemented as part of the Progress class, which gives you the automatic update, and a captures stdout so it won't break the visuals.",
"created_at": "2020-11-01T11:14:40Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Threads are tricky.",
"created_at": "2020-11-01T11:21:24Z",
"type": "review",
"review_state": "COMMENTED"
}
]
},
{
"pr_number": 407,
"pr_title": "Allow subclassing RichHandler",
"pr_url": "https://github.com/Textualize/rich/pull/407",
"pr_author": "pwwang",
"created_at": "2020-10-25T06:18:46Z",
"closed_at": "2020-10-31T14:45:01Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Sorry for the delay. I think this is a worthwhile addition and I appreciate the work you put in to this, but I think I'd like to tackle it in a different way. I was unaware that you can set level names in the logging library itself, and another solution may be required.\r\n\r\nI'll have a change to master soon.",
"created_at": "2020-10-31T13:52:38Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Closing in favour of https://github.com/willmcgugan/rich/pull/419",
"created_at": "2020-10-31T14:45:01Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 403,
"pr_title": "Allow level name of `RichHandler` to be customized",
"pr_url": "https://github.com/Textualize/rich/pull/403",
"pr_author": "pwwang",
"created_at": "2020-10-23T20:23:00Z",
"closed_at": "2020-10-24T14:10:35Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Sorry, I'm not keen on this. I prefer not to overload parameters like that, I find having an argument that may be two quite different types tends to make typing difficult and makes the code harder to reason about.\r\n\r\nI understand why you would want this functionality, but trying to pack everyone's use case in to a single class leads to difficult to maintain code.\r\n\r\nWhat I would accept is a change that allows you to specify level names via inheritance. Say by having a class var that stores the level names. So you could create a custom handler class along these lines:\r\n\r\n```python\r\nclass MyHandler(RichHandler):\r\n levels = {\r\n 10: \"D Debug\",\r\n 20: \"I Info\",\r\n }\r\n```",
"created_at": "2020-10-24T13:52:22Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "I'd suggest adding a level_width parameter to the LogRender class. You could calculate the maximum width required in the handler.",
"created_at": "2020-10-24T15:04:40Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 371,
"pr_title": "Add tests for regular expression",
"pr_url": "https://github.com/Textualize/rich/pull/371",
"pr_author": "deppiedave64",
"created_at": "2020-10-09T18:10:51Z",
"closed_at": "2020-10-14T10:45:09Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "This is solved in Master. I made some improvements to the highlighter system. Thanks @deppiedave64 for prompting me to look at this.",
"created_at": "2020-10-14T10:45:09Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 356,
"pr_title": "Avoid codecov spam",
"pr_url": "https://github.com/Textualize/rich/pull/356",
"pr_author": "ssbarnea",
"created_at": "2020-10-07T09:06:50Z",
"closed_at": "2020-10-08T09:36:25Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "I think I explained previously that I find the codecov comment useful.",
"created_at": "2020-10-08T09:36:25Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 354,
"pr_title": "Fixed pip editable install",
"pr_url": "https://github.com/Textualize/rich/pull/354",
"pr_author": "ssbarnea",
"created_at": "2020-10-07T08:48:05Z",
"closed_at": "2020-10-07T09:30:37Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "`poetry install` does an editable install.\r\n\r\nTested with a fresh venv, and it works fine. rich.__file__ points to the local dir, not to site packages.",
"created_at": "2020-10-07T09:14:59Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "It wouldn't work for me anyway. Py27 is still the default in MacOS\r\n\r\nRegardless, installing in your system Python is not a good idea. And I don't want to muddy the waters with two ways of installing it for development.\r\n\r\nIf you have identified a problem with installs, you might want to post an issue on poetry repos.",
"created_at": "2020-10-07T09:30:37Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Like I said, it's a bad idea to do an editable install in system python.\r\n\r\nUse a venv, it works regardless of current working directory.\r\n\r\nPlease read https://python-poetry.org/docs/basic-usage/ Particularly the section on virtual envs.",
"created_at": "2020-10-07T10:36:50Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 352,
"pr_title": "Fix rich.print for dict-inherited objects",
"pr_url": "https://github.com/Textualize/rich/pull/352",
"pr_author": "nathanielCherian",
"created_at": "2020-10-07T00:28:05Z",
"closed_at": "2020-10-07T07:43:49Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "It's not broken. See issue.",
"created_at": "2020-10-07T07:43:49Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 347,
"pr_title": "Make soft_wrap preference configurable per Console",
"pr_url": "https://github.com/Textualize/rich/pull/347",
"pr_author": "ssbarnea",
"created_at": "2020-10-06T14:44:50Z",
"closed_at": "2020-10-08T09:39:22Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "I wouldn't accept this. It would break third party code if soft_wrap is enabled by default, forcing everyone to add `soft_wrap` to their print statements to be sure it would output what they expect.\r\n\r\nIf you need it, I'd suggest writing a function that calls print with soft_wrap=False.",
"created_at": "2020-10-06T14:56:10Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "If you print a third party renderable to a console with soft wrapping disabled, it may product broken output. It doesn't really fix anything, just save a little typing, at the expense of potentially breaking thing. Sorry, can't merge this. ",
"created_at": "2020-10-06T15:17:37Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 337,
"pr_title": "Increase Coverage",
"pr_url": "https://github.com/Textualize/rich/pull/337",
"pr_author": "nestoralonso",
"created_at": "2020-10-04T22:51:11Z",
"closed_at": "2020-10-08T09:55:43Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "There's another PR for Syntax tests with greater coverage. Thanks anyway.",
"created_at": "2020-10-08T09:55:43Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 336,
"pr_title": "Missing commonmark in requirements-dev.txt",
"pr_url": "https://github.com/Textualize/rich/pull/336",
"pr_author": "nestoralonso",
"created_at": "2020-10-04T20:38:18Z",
"closed_at": "2020-10-04T22:54:39Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Did you follow the procedure in Contributing.md?",
"created_at": "2020-10-04T21:09:53Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 335,
"pr_title": "Added An Example to show the use of Rainbow text with an Array output",
"pr_url": "https://github.com/Textualize/rich/pull/335",
"pr_author": "NicholasBlackburn1",
"created_at": "2020-10-04T20:37:32Z",
"closed_at": "2020-10-04T21:58:00Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "What feature of Rich does this demonstrate?",
"created_at": "2020-10-04T20:58:12Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Sorry. I don't think this adds any value. Examples should demonstrate a feature not already covered.",
"created_at": "2020-10-04T21:57:51Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 329,
"pr_title": "Update rainbow.py",
"pr_url": "https://github.com/Textualize/rich/pull/329",
"pr_author": "Jamesbond8002",
"created_at": "2020-10-04T06:58:00Z",
"closed_at": "2020-10-04T09:19:49Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Sorry, Bond. You\u2019ll need more than just comments for this mission.",
"created_at": "2020-10-04T09:19:49Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 328,
"pr_title": "progressbar use decimal units",
"pr_url": "https://github.com/Textualize/rich/pull/328",
"pr_author": "oleksis",
"created_at": "2020-10-03T21:12:06Z",
"closed_at": "2020-10-05T17:54:42Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "@oleksis There is already a [PR](https://github.com/willmcgugan/rich/pull/326) in the works for this one. Probably should wait for @amartya-dev\r\n\r\nBut yeah, changelog and test will be required...",
"created_at": "2020-10-03T21:24:09Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Work done in https://github.com/willmcgugan/rich/pull/326 Thanks anyway!",
"created_at": "2020-10-05T17:54:33Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 327,
"pr_title": "Add fix for not callable attribute \"__rich__\", \"__rich_console__\"",
"pr_url": "https://github.com/Textualize/rich/pull/327",
"pr_author": "ubaumann",
"created_at": "2020-10-03T21:05:51Z",
"closed_at": "2020-10-08T10:10:59Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "I suspect that would still blow up elsewhere in the api.\r\n\r\nThe magic that `addict` is doing is going to break any kind of introspection. Could you just convert it to a dict with `dict(data)`?\r\n",
"created_at": "2020-10-04T12:21:54Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "It's unfortunate, but I don't think I should merge this one. I think the way `addict` reports that all attributes exist, is an anti-pattern if not a bug. ",
"created_at": "2020-10-08T10:10:59Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 296,
"pr_title": "Use and display panels in rich.columns",
"pr_url": "https://github.com/Textualize/rich/pull/296",
"pr_author": "oleksis",
"created_at": "2020-09-20T04:34:24Z",
"closed_at": "2020-09-20T14:05:29Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "That was a throw-away piece of code for testing columns. There's not much point in maintaining any code in main blocks unless I've mentioned it in the docs...",
"created_at": "2020-09-20T13:32:13Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 288,
"pr_title": "Remove align argument from table Column example",
"pr_url": "https://github.com/Textualize/rich/pull/288",
"pr_author": "paw-lu",
"created_at": "2020-09-17T03:30:20Z",
"closed_at": "2020-09-18T15:17:42Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Good spot. I think there is an API wart there, in that the `index` value in Column should be public. I've fixed that in another branch as well as the docs. Thanks for drawing my attention to it.",
"created_at": "2020-09-18T15:17:42Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 260,
"pr_title": "Add the ability to force terminal with environment variable",
"pr_url": "https://github.com/Textualize/rich/pull/260",
"pr_author": "nathanrpage97",
"created_at": "2020-08-31T19:43:58Z",
"closed_at": "2020-08-31T22:36:15Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "I don't think this a good idea. I wouldn't want to presume how the application developer would like to configure their environment. It would also effect all Console instances, which might not be desirable.\r\n\r\nIf you do need it, it's a straightforward thing to implement as required.",
"created_at": "2020-08-31T21:57:30Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 187,
"pr_title": "Replace all imports from rich with relative imports.",
"pr_url": "https://github.com/Textualize/rich/pull/187",
"pr_author": "clintonc",
"created_at": "2020-07-29T05:03:27Z",
"closed_at": "2020-07-31T09:29:59Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Reliable builds wouldn\u2019t work if you install things under a different name. Besides, the core lib is all relative. The absolute imports are all in the main sections.\r\n\r\nIf you need this, add a test that increases coverage and I\u2019ll consider merging.",
"created_at": "2020-07-30T07:45:40Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 183,
"pr_title": "Fix header in rich.emoji docs",
"pr_url": "https://github.com/Textualize/rich/pull/183",
"pr_author": "fenilgandhi",
"created_at": "2020-07-26T22:17:32Z",
"closed_at": "2020-07-27T16:48:21Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Done in another branch. Thanks.",
"created_at": "2020-07-27T16:48:21Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 114,
"pr_title": "Removes unused imports",
"pr_url": "https://github.com/Textualize/rich/pull/114",
"pr_author": "sondrelg",
"created_at": "2020-06-19T13:53:51Z",
"closed_at": "2020-06-21T11:35:10Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Thanks, I should set up linting to find these in future. \r\n\r\nI'm getting a number of test fails. You can run tests with `make test`. Looks like a little too much pruning of imports...",
"created_at": "2020-06-19T15:49:58Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "I've just enabled the tests to run on pull request with Github Actions. So hopefully test errors will show up here.",
"created_at": "2020-06-19T15:57:30Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "That\u2019s strange! Tests on master pass for me locally on OSX, and in Github Actions. Can you give me an example of the failing tests?\r\n\r\nWhat platform, Python version, are you using.",
"created_at": "2020-06-20T08:38:57Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Ah, you're on Windows. Rich renders a few things a little differently if it detects Windows, as cmd.exe doesn't support some unicode characters such as those used rendering progress bars.\r\n\r\nI think the solution may be a flag on the Console object to override the Windows auto-detection, so the the output is the same as OSX/Linux.\r\n\r\n> This specific test could possibly be failing because of line 5: from render import render. What package is this?\r\n\r\nThats importing from render.py in the same directory. Not sure why it's not finding that file.\r\n\r\nSo there's obviously a bit of work to do to support development on Windows, and setting up a development environment in general. I think I will look at that next. Perhaps I should merge your PR as is (test fails are minor and easy fixed). Then I'll work on the Windows / dev environment issues. How does that sound?",
"created_at": "2020-06-20T11:31:54Z",
"type": "comment",
"review_state": null
},
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "I've done the work in another branch, and also cleaned up the unused imports. Thanks for prompting me to do this, it was overdue.",
"created_at": "2020-06-21T11:35:10Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 107,
"pr_title": "enable emojis for rich logging handler",
"pr_url": "https://github.com/Textualize/rich/pull/107",
"pr_author": "smacke",
"created_at": "2020-06-08T20:38:53Z",
"closed_at": "2020-06-09T16:51:16Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Thanks for the PR, but I'm afraid I'm not keen on enabling emoji code in logging. The emoji isn't going to be replaced in all handlers, and the function to do the replace is fast but not free in terms of cpu.\r\n\r\nIf you want emoji in your logs my suggestion would be to either copy RichHandler to your own project and customize it, or define a logging Formatter that does the emoji replace. The later is probably better because you could get emoji an all handlers.",
"created_at": "2020-06-09T09:25:24Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 91,
"pr_title": "Attempt at solving progress bar deadlock",
"pr_url": "https://github.com/Textualize/rich/pull/91",
"pr_author": "eulertour",
"created_at": "2020-05-24T11:03:46Z",
"closed_at": "2020-05-24T12:14:33Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "Thanks. I'll get back to you after I've looked in to the deadlock in more detail.",
"created_at": "2020-05-24T11:13:36Z",
"type": "comment",
"review_state": null
}
]
},
{
"pr_number": 63,
"pr_title": "Added code coverage, fixed makefile, cleaned the github workflow",
"pr_url": "https://github.com/Textualize/rich/pull/63",
"pr_author": "kkapka",
"created_at": "2020-05-09T15:07:25Z",
"closed_at": "2020-05-13T20:35:39Z",
"maintainer_comments": [
{
"author": "willmcgugan",
"author_association": "MEMBER",
"body": "You closed? Sorry if I was taking my time, I was planning on merging...",
"created_at": "2020-05-13T20:37:36Z",
"type": "comment",
"review_state": null
}
]
}
]
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment