Skip to content

Instantly share code, notes, and snippets.

@meowterspace
Created July 12, 2019 09:37
Show Gist options
  • Select an option

  • Save meowterspace/8dda20f2c15f9cb20280a076c757cf07 to your computer and use it in GitHub Desktop.

Select an option

Save meowterspace/8dda20f2c15f9cb20280a076c757cf07 to your computer and use it in GitHub Desktop.
GitHub Review Comments
  • Pass only important things into function.

  • Don't put things in a try/except if they can't raise the error you're catching

  • Use specific logger.errors not general. E.g. Generating Auth0 user from PIO failed with error {e}

  • Don't return False unless you're also returning True. E.g. if returning an object or not, just return an object, or don't -> Null

  • Don't return Null unless you have to. Not returning anything will return Null.

  • Keep it simple

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment