Slightly unrelated to you requesting feedback on the "each" portion, but I think you want attr_reader instead of attr_accessor. You're passing in start_time and end_time in the constructor, and likely want those attributes immutable after object instantiation.

you may find this more useful

require 'date'
.
.
.
.
.
def each_day
(@start_time.to_date..@end_time.to_date).to_a.each do |date|
yield date
end
end

of course this returns the date object only and not a time object.

@johnkary I'm just in the lazy habit of using attr_accessor. I'm a horrible person.

@KellyMahan The #each method is a special method used by the Enumerable module. When you define each in a class in which Enumerable has been included, you get instant access to most of Enumerable's methods (in this case, I wanted map).

But you're right, each_day would be much better, and so I think changing the name of the class might make each make a little more sense. I may change it to Daterange or Dayrange. Not sure.

Really appreciate the feedback.