- (Edit the above to reflect status)
- TL;DR - what's this PR for?
- When does this need to be merged by?
| # Good Enough Testing | |
| This document outlines the philosophy of "Good Enough Testing" and provides practical guidelines for ensuring that the website functions as intended without over-investing in exhaustive test coverage. | |
| --- | |
| ## Philosophy | |
| Testing is not about achieving perfection. It is about ensuring that the website: | |
| 1. **Does what it is supposed to do**: Verify that key features and functionality work as expected. |
| /** Delete a record based on finding record id in the 2way link field venue **/ | |
| const table = base.getTable("Web Only"); | |
| const inputConfig = input.config(); | |
| const recordId = inputConfig['recordId']; | |
| const fieldName = 'Venue'; | |
| // Can't query just by a field value so we have to get all the fields and loop through them. | |
| const queryResult = await table.selectRecordsAsync({fields: ['Name', fieldName]}) | |
| const matchingRecords = queryResult.records.filter((record) => { | |
| const vals = record.getCellValue(fieldName); | |
| if (vals && vals[0] && vals[0].id && vals[0].id == recordId) { |
| import React from 'react' | |
| import Components from '../components/components.js' | |
| import SbEditable from 'storyblok-react' | |
| import config from '../../gatsby-config' | |
| import Loader from 'react-loader-spinner' | |
| const sbConfigs = config.plugins.filter((item) => { | |
| return item.resolve === 'gatsby-source-storyblok' | |
| }) | |
| const sbConfig = sbConfigs.length > 0 ? sbConfigs[0] : {} |
| LANDO FILE: | |
| ---------------------------------------------------- | |
| name: cardinalsites | |
| recipe: drupal8 | |
| config: | |
| webroot: docroot | |
| php: '7.3' | |
| xdebug: true | |
| services: | |
| appserver: |
| #!/bin/csh | |
| ################## | |
| # Variables | |
| ################## | |
| # Path to a place to store your sites. | |
| WEBSERVERROOT=/httpdocs #no trailing slash | |
| # Path to your lando configuration file for Drupal 7 | |
| LANDOCONFIG=/Users/admin/scripts/su/d7.lando.yml |
| name: [shortname] | |
| recipe: drupal7 | |
| config: | |
| webroot: / | |
| php: '7.1' | |
| services: | |
| appserver: | |
| ssl: true | |
| database: | |
| type: mysql:5.7 |
| #!/bin/csh | |
| ################## | |
| # Variables | |
| ################## | |
| # Path to a place to store your sites. | |
| WEBSERVERROOT=/httpdocs #no trailing slash | |
| # Path to your lando configuration file for Drupal 7 | |
| LANDOCONFIG=/Users/admin/scripts/su/d7.lando.yml |
| <?php | |
| /** | |
| * SimplePie | |
| * | |
| * A PHP-Based RSS and Atom Feed Framework. | |
| * Takes the hard work out of managing a complete RSS/Atom solution. | |
| * | |
| * Please note: This file is automatically generated by a build script. The | |
| * full original source is always available from http://simplepie.org/ | |
| * |
| diff --git a/core/modules/page_cache/src/StackMiddleware/PageCache.php b/core/modules/page_cache/src/StackMiddleware/PageCache.php | |
| index 6eb4742..ba495fd 100644 | |
| --- a/core/modules/page_cache/src/StackMiddleware/PageCache.php | |
| +++ b/core/modules/page_cache/src/StackMiddleware/PageCache.php | |
| @@ -283,10 +283,15 @@ protected function storeResponse(Request $request, Response $response) { | |
| $expire = $request_time + $cache_ttl_4xx; | |
| } | |
| } | |
| - else { | |
| - $date = $response->getExpires()->getTimestamp(); |