Skip to content

Instantly share code, notes, and snippets.

@viniciusjssouza
Created July 4, 2020 14:58
Show Gist options
  • Select an option

  • Save viniciusjssouza/19bf31c7b09a968b11ffd0ca10c62a2c to your computer and use it in GitHub Desktop.

Select an option

Save viniciusjssouza/19bf31c7b09a968b11ffd0ca10c62a2c to your computer and use it in GitHub Desktop.
Code review - What to look for

Code Reviews

Functionality (high)

  • Do the code provide the desired functionality correctly? Are there any possible bugs?

Tests (high)

  • Does the code have tests for all the "complex" logics in it?
  • Are the tests maintainable and well designed?
  • Do they respect the test pyramid to avoid taking so much time to run?

Performance (medium to high)

  • Are there any performance bootlenecks? Queries, loops, response times, etc.

Design (medium to high)

  • Does the code follows the project/company standards?
  • Is it duplicating stuff?
  • Are there other (better) ways of implemeting it? (maybe design partterns)

Naming (low to medium)

  • Do the code uses clear and meaningful names for variables, functions and classes?

Complexity (low to medium)

  • Are they simpler ways of doing the same thing? Maybe the complexity is necessary for performance reasons.

Comments (low to medium)

  • Do the "not so clear" parts have comments? Should it be refactored?

Documentation (low)

  • Should it update the project documentation?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment