Reviews are an essential step of the development process. They are also the best way to improve a team's skills and quality of the code. Every review and comment should be treated as a growth opportunity.
Approval & Approvers
- Merge requests need to have two format approvals from any of the people with the right to do so in the project.
- Approval right is earned through active reviewing on own team & other teams MR's
- Approval right can be lost
- Feature -> Master MR's that already had it's content review through task -> feature MR's don't need actual review/approval but that's not something we can configure in gitlab so approvals should be given as soon as such a MR appears.
Code Review Best Practices